Remove skips from doctests (4 of 6)#7865
Conversation
| When what you really wanted was more along the lines of the following: | ||
|
|
||
| >>> list(fizzbuzzz) # doctest: +SKIP | ||
| [(0, 0), (3, None), (None, 5), (6, None), (None 10), (9, None), | ||
| (12, None), (15, 15), (18, None), (None, 20), (None, 25), (None, 30)] | ||
| >>> list(fizzbuzz) # doctest: +SKIP | ||
| (0, 0), (3, None), (None, 5), (6, None), (9, None), (None, 10), | ||
| (12, None), (15, 15), (18, None), (None, 20), | ||
| (21, None), (24, None), (None, 25), (27, None), (30, 30) |
There was a problem hiding this comment.
Re the following comment, it's not clear to me what the original author was going for, so I took my best guess.
When what you really wanted was more along the lines of the following
There was a problem hiding this comment.
huh yeah. I am not sure either. I guess what you have is fine but just wrap it in square brackets like the original.
There was a problem hiding this comment.
Will do.
Only problem is I'd accidentally deleted my fork so can't push changes to the feature branch. As seen below, the feature branch is grayed out and can no longer be clicked on (normally clicking on it takes you to the fork). This applies to #7864 as well.
Any idea what I can do here without having to open a new PR? I do still have access to the fork locally so no work is lost but I'd prefer not to open a new PR if possible.
There was a problem hiding this comment.
Oh wierd. I am going to see if I can still push.
There was a problem hiding this comment.
I'm just going to merge this since the last comment is about a skipped doctest output.
| >>> import dask.bag as db # doctest: +SKIP | ||
| ... from dask.bag import random | ||
| ... | ||
| ... b = db.from_sequence(range(5), npartitions=2) | ||
| ... list(random.sample(b, 3).compute()) | ||
| >>> import dask.bag as db | ||
| >>> from dask.bag import random | ||
| >>> b = db.from_sequence(range(5), npartitions=2) | ||
| >>> list(random.sample(b, 3).compute()) # doctest: +SKIP |
There was a problem hiding this comment.
Moving the SKIP to the actual line that we want to skip feels more intuitive in my opinion.
zzhengnan
changed the title
|
@jsignell Ready for review. |
2 participants
This is one of 6 PRs that collectively addresses #7823. Please see #7823 (comment) for more context.
Links to all 6 PRs