Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idle timeout without client attached #7959

Open
mrocklin opened this issue Jul 3, 2023 · 6 comments · May be fixed by #8105 or #8757
Open

Idle timeout without client attached #7959

mrocklin opened this issue Jul 3, 2023 · 6 comments · May be fixed by #8105 or #8757
Labels
enhancement Improve existing functionality or make things work better good first issue Clearly described and easy to accomplish. Good for beginners to the project.

Comments

@mrocklin
Copy link
Member

mrocklin commented Jul 3, 2023

Currently we have an idle_timeout= keyword. It's great! It stops people from leaving clusters on, potentially racking up needless cloud expenses.

I sometimes find myself wanting a different timeout when all clients have gone. For example I might want a one-hour timeout if I'm connected from my Jupyter session, but once I've disconnected I probably only want a five minute timeout (long enough for me to hit refresh on my notebook and reconnect).

With this in mind I'll propose a idle_timeout_no_clients= keyword and config value (better names welcome) that would, presumably, be set more aggressively.

cc @fjetter @jrbourbeau (maybe useful for coiled.run) and @ntabris (because I think he cares about these things).

@fjetter fjetter added enhancement Improve existing functionality or make things work better good first issue Clearly described and easy to accomplish. Good for beginners to the project. and removed needs triage labels Jul 5, 2023
@mercyo12
Copy link
Contributor

@fjetter Hi, could I make a PR for this issue? Thanks!

@jacobtomlinson
Copy link
Member

@mercyo12 please go ahead!

@fjetter
Copy link
Member

fjetter commented Jul 24, 2023

@mercyo12 sure. If you need any pointers, either ask on this issue or open a draft PR with your work in progress.

Contributions are always welcome :)

@mercyo12
Copy link
Contributor

mercyo12 commented Aug 4, 2023

hi, would we want to have both idle_timeout and idle_timeout_no_clients on at the same time, or if one is enabled the other isn't? thanks for the clarification!

@fjetter
Copy link
Member

fjetter commented Aug 7, 2023

I think the intention here is to have two distinct values and it should be possible to set and enable both at the same time.

@mercyo12 mercyo12 linked a pull request Aug 14, 2023 that will close this issue
2 tasks
@crusaderky
Copy link
Collaborator

crusaderky commented Aug 15, 2023

(ignore my previous post; I didn't consider that tasks will be forgotten as soon as the client leaves unless they're fire-and-forget)

@tmi tmi linked a pull request Jul 10, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or make things work better good first issue Clearly described and easy to accomplish. Good for beginners to the project.
Projects
None yet
5 participants