Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that we respect shuffle in context manager #958

Merged
merged 5 commits into from
Mar 8, 2024
Merged

Ensure that we respect shuffle in context manager #958

merged 5 commits into from
Mar 8, 2024

Conversation

phofl
Copy link
Collaborator

@phofl phofl commented Mar 8, 2024 •
edited by crusaderky
Loading

@phofl phofl mentioned this pull request Mar 8, 2024
Merged
hendrikmakait
hendrikmakait approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @phofl!

dask_expr/_util.py Outdated Show resolved Hide resolved
dask_expr/tests/test_shuffle.py Outdated Show resolved Hide resolved
phofl and others added 3 commits March 8, 2024 16:13
@phofl @hendrikmakait
Update dask_expr/_util.py
6a29553 
Co-authored-by: Hendrik Makait <hendrik@makait.com>
@phofl @hendrikmakait
Update dask_expr/tests/test_shuffle.py
c3d2957 
Co-authored-by: Hendrik Makait <hendrik@makait.com>
@phofl
Update test_shuffle.py
4be7eaf
@phofl phofl merged commit 4915998 into dask:main Mar 8, 2024
5 of 7 checks passed
@phofl phofl deleted the shuffle_context branch March 8, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendrikmakait hendrikmakait hendrikmakait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @hendrikmakait