Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Auth to dockercfgsecret #20

Closed
andrewl3wis opened this issue Jul 8, 2019 · 1 comment
Closed

Add Auth to dockercfgsecret #20

andrewl3wis opened this issue Jul 8, 2019 · 1 comment

Comments

@andrewl3wis
Copy link

Hey, it'd be great if DOCKERCFGSECRET was harmonized with the format that is created by kubectl and added an the auth field to the secret that is created in k8s, while not necessary for the the secret to work with kubernetes for image pulls, some external tools like Weavework's flux expect it to exist(fluxcd/flux#1596).

In the 1.13.0 release of kubectl they had also stripped out the auth field, but then re-added it in kubernetes/kubernetes#72344
DaspawnW pushed a commit that referenced this issue Jul 9, 2019
Fix dockercfgsecretmissing auth field in JSON object #20
4448f22
DaspawnW added a commit that referenced this issue Jul 9, 2019
@DaspawnW
Merge pull request #21 from DaspawnW/bugfix/dockerpullsecret
ba6d3bb 
Fix dockercfgsecretmissing auth field in JSON object #20
@DaspawnW
Copy link
Owner

DaspawnW commented Jul 9, 2019

Release 1.2.3 containing bugfix will be available in few minutes.

@DaspawnW DaspawnW closed this as completed Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DaspawnW @andrewl3wis