Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DOCKERCFG in a version 2 KV store #27

Closed
nealf opened this issue Nov 24, 2019 · 1 comment · Fixed by #31
Closed

Support DOCKERCFG in a version 2 KV store #27

nealf opened this issue Nov 24, 2019 · 1 comment · Fixed by #31

Comments

@nealf
Copy link

nealf commented Nov 24, 2019

It appears as though the DOCKERCFG Secret Type does not currently work with a Version 2 KV secret engine in Vault. I had to create a new version 1 KV store in Vault and put Docker credentials in it in order for vault-crd to properly create the kubernetes.io/dockercfg secret.

As a quick solution, it would be nice to just document that DOCKERCFG requires a v1 secret engine to save others the time of working through this issue. :-)

Thanks for the great project!

@DaspawnW
Copy link
Owner

Hi @nealf,

thnx for the feature request and sorry for my late response.
I've created a new release that contains support for version 2 KV store of Vault: https://github.com/DaspawnW/vault-crd/releases/tag/1.4.0

Cheers,
Björn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants