-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change all Circle arguments for 'radius' to 'area' #407
Comments
To represent a magnitude, area is more appropriate than length based on
visualization principles. I think we therefore need to live with the
inconsistency or change everything else to area.
…On Tue, Aug 6, 2019 at 11:33 PM Adnan Hemani ***@***.***> wrote:
This is to be consistent with how we've been drawing circles everywhere
else around the Maps module
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#407?email_source=notifications&email_token=AACOFEJFQRP4E36GFHGBKQLQDJUEFA5CNFSM4IJ43AK2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HDZUAZA>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACOFEN6GUAMWYRPNIZAOXLQDJUEFANCNFSM4IJ43AKQ>
.
|
The other place where this is partly used is in the So just to confirm, you think it would be better to change the Circle to only have an area property that can be changed rather than radius if we want to make everything consistent? Thanks for chiming in on this! :) |
Yeah, areas everywhere is the best way to be consistent. Radius-based sizes
based on data are very misleading —- large values look huge. The bike
sharing data set from lecture ran into this problem before I switched from
radius to area.
…On Wed, Aug 7, 2019 at 11:00 PM Adnan Hemani ***@***.***> wrote:
The other place where this is partly used is in the radius argument of
Circle. I do think that we need to be consistent across this because it
makes no sense to have to instantiate a Circle using a radius parameter -
while having to pass in the area of the circle as a column to the table
when trying to recreate the same Circle using the map method.
So just to confirm, you think it would be better to change the Circle to
only have an area property that can be changed rather than radius if we
want to make everything consistent? Thanks for chiming in on this! :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#407?email_source=notifications&email_token=AACOFELSYPYIINOFYIOB36LQDOY6TA5CNFSM4IJ43AK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD32RESA#issuecomment-519377480>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACOFENC6ITN6TZLO2ESFATQDOY6TANCNFSM4IJ43AKQ>
.
|
This is to be consistent with how we've been drawing circles everywhere else around the Maps module
The text was updated successfully, but these errors were encountered: