You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
for col in self._columns:
self._columns[col] = [elem for i, elem in enumerate(self[col]) if i not in rows_remove]
It creates a list, not an array. I believe this should be fixed to create an array.
(Seeing as .remove() is also side-effecting and we are trying to promote non-side-effecting methods where appropriate, we could consider deprecating .remove() anyway and pointing people to .exclude().)
Thanks to Dan Kaiser for this bug report.
The text was updated successfully, but these errors were encountered:
When using
Table.remove()
, the type of the columns in a table become lists. They should remain arrays. See attached notebook for an example.TableRemoveOddity.zip
Sample code to reproduce:
Looking at the implementation of
.remove()
(https://github.com/data-8/datascience/blob/master/datascience/tables.py#L1118), we can immediately see the problem:It creates a list, not an array. I believe this should be fixed to create an array.
(Seeing as
.remove()
is also side-effecting and we are trying to promote non-side-effecting methods where appropriate, we could consider deprecating.remove()
anyway and pointing people to.exclude()
.)Thanks to Dan Kaiser for this bug report.
The text was updated successfully, but these errors were encountered: