Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Include all FetchOptions in subscribe action #265

Merged
merged 3 commits into from
Feb 12, 2020
Merged

feat: Include all FetchOptions in subscribe action #265

merged 3 commits into from
Feb 12, 2020

Conversation

kmartinezmedia
Copy link
Contributor

@kmartinezmedia kmartinezmedia commented Feb 12, 2020 •
edited by ntucker
Loading

Motivation

  • This allows custom FetchShapes to include options that a custom Middleware can hook into. useSubscription was previously only pulling pollFrequency from options. This now includes all options in meta object.

Solution

  • subscribe/unsubscribe actions now include all FetchOptions, rather than just frequency (BREAKING)
  • Add 'extra' member to FetchOptions

@kmartinezmedia kmartinezmedia changed the title Update useSubscription to include all options in dispatched meta feat: Include all FetchOptions in subscribe action Feb 12, 2020
@ntucker ntucker merged commit e27f420 into reactive:master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntucker ntucker ntucker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmartinezmedia @ntucker