Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JSON.parse call from homebrew-tap action #1393

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

andrewnester
Copy link
Contributor

Changes

needs.goreleaser.outputs.artifacts already contains valid JS object so no need to make it a string and try to parse

@pietern pietern changed the title Remove JSON.parse call from homebrew-tap action Remove JSON.parse call from homebrew-tap action Apr 23, 2024
@andrewnester andrewnester added this pull request to the merge queue Apr 23, 2024
Merged via the queue into main with commit d99f2b8 Apr 23, 2024
5 checks passed
@andrewnester andrewnester deleted the fix-cli-actions branch April 23, 2024 13:37
pietern added a commit that referenced this pull request Apr 25, 2024
This is a bugfix release.

CLI:
 * Pass `DATABRICKS_CONFIG_FILE` for `auth profiles` ([#1394](#1394)).

Bundles:
 * Show a better error message for using wheel tasks with older DBR versions ([#1373](#1373)).
 * Allow variable references in non-string fields in the JSON schema ([#1398](#1398)).
 * Fix variable overrides in targets for non-string variables ([#1397](#1397)).
 * Fix bundle schema for variables ([#1396](#1396)).
 * Fix bundle documentation URL ([#1399](#1399)).

Internal:
 * Removed autogenerated docs for the CLI commands ([#1392](#1392)).
 * Remove `JSON.parse` call from homebrew-tap action ([#1393](#1393)).
 * Ensure that Python dependencies are installed during upgrade ([#1390](#1390)).
@pietern pietern mentioned this pull request Apr 25, 2024
github-merge-queue bot pushed a commit that referenced this pull request Apr 25, 2024
This is a bugfix release.

CLI:
* Pass `DATABRICKS_CONFIG_FILE` for `auth profiles`
([#1394](#1394)).

Bundles:
* Show a better error message for using wheel tasks with older DBR
versions ([#1373](#1373)).
* Allow variable references in non-string fields in the JSON schema
([#1398](#1398)).
* Fix variable overrides in targets for non-string variables
([#1397](#1397)).
* Fix bundle schema for variables
([#1396](#1396)).
* Fix bundle documentation URL
([#1399](#1399)).

Internal:
* Removed autogenerated docs for the CLI commands
([#1392](#1392)).
* Remove `JSON.parse` call from homebrew-tap action
([#1393](#1393)).
* Ensure that Python dependencies are installed during upgrade
([#1390](#1390)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants