Fix variable overrides in targets for non-string variables #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-goenka
requested review from
pietern and
andrewnester
and removed request for
pietern
pietern
approved these changes
Apr 25, 2024
pietern
added a commit
that referenced
this pull request
Apr 25, 2024
This is a bugfix release. CLI: * Pass `DATABRICKS_CONFIG_FILE` for `auth profiles` ([#1394](#1394)). Bundles: * Show a better error message for using wheel tasks with older DBR versions ([#1373](#1373)). * Allow variable references in non-string fields in the JSON schema ([#1398](#1398)). * Fix variable overrides in targets for non-string variables ([#1397](#1397)). * Fix bundle schema for variables ([#1396](#1396)). * Fix bundle documentation URL ([#1399](#1399)). Internal: * Removed autogenerated docs for the CLI commands ([#1392](#1392)). * Remove `JSON.parse` call from homebrew-tap action ([#1393](#1393)). * Ensure that Python dependencies are installed during upgrade ([#1390](#1390)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
This is a bugfix release. CLI: * Pass `DATABRICKS_CONFIG_FILE` for `auth profiles` ([#1394](#1394)). Bundles: * Show a better error message for using wheel tasks with older DBR versions ([#1373](#1373)). * Allow variable references in non-string fields in the JSON schema ([#1398](#1398)). * Fix variable overrides in targets for non-string variables ([#1397](#1397)). * Fix bundle schema for variables ([#1396](#1396)). * Fix bundle documentation URL ([#1399](#1399)). Internal: * Removed autogenerated docs for the CLI commands ([#1392](#1392)). * Remove `JSON.parse` call from homebrew-tap action ([#1393](#1393)). * Ensure that Python dependencies are installed during upgrade ([#1390](#1390)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before variable overrides that were not string in a target would not work. This PR fixes that. Tested manually and via a unit test.