Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bundle schema for variables #1396

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Fix bundle schema for variables #1396

merged 2 commits into from
Apr 25, 2024

Conversation

shreyas-goenka
Copy link
Contributor

@shreyas-goenka shreyas-goenka commented Apr 24, 2024 •
edited
Loading

Changes

This PR fixes the variable schema to:

  1. Allow non-string values in the "default" value of a variable.
  2. Allow non-string overrides in a target for a variable.

Tests

Manually. There are no longer squiggly lines.

Before:
Screenshot 2024-04-24 at 3 26 43 PM

After:
Screenshot 2024-04-24 at 3 26 10 PM

@shreyas-goenka
Copy link
Contributor Author

shreyas-goenka commented Apr 24, 2024 •
edited
Loading

Upcoming changes:

  1. Fix the resolution of non-string variable overrides in the target.
  2. Remove red squiggly lines for variable values in API fields. We can do this by allowing string values in all fields that allow variable interpolation.

@shreyas-goenka shreyas-goenka added this pull request to the merge queue Apr 25, 2024
Merged via the queue into main with commit d949f2b Apr 25, 2024
5 checks passed
@shreyas-goenka shreyas-goenka deleted the fix/bundle-schema branch April 25, 2024 11:30
pietern added a commit that referenced this pull request Apr 25, 2024
@pietern
Release v0.218.1
5ab36c9 
This is a bugfix release.

CLI:
 * Pass `DATABRICKS_CONFIG_FILE` for `auth profiles` ([#1394](#1394)).

Bundles:
 * Show a better error message for using wheel tasks with older DBR versions ([#1373](#1373)).
 * Allow variable references in non-string fields in the JSON schema ([#1398](#1398)).
 * Fix variable overrides in targets for non-string variables ([#1397](#1397)).
 * Fix bundle schema for variables ([#1396](#1396)).
 * Fix bundle documentation URL ([#1399](#1399)).

Internal:
 * Removed autogenerated docs for the CLI commands ([#1392](#1392)).
 * Remove `JSON.parse` call from homebrew-tap action ([#1393](#1393)).
 * Ensure that Python dependencies are installed during upgrade ([#1390](#1390)).
@pietern pietern mentioned this pull request Apr 25, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Apr 25, 2024
@pietern
Release v0.218.1 (#1401)
a292eef 
This is a bugfix release.

CLI:
* Pass `DATABRICKS_CONFIG_FILE` for `auth profiles`
([#1394](#1394)).

Bundles:
* Show a better error message for using wheel tasks with older DBR
versions ([#1373](#1373)).
* Allow variable references in non-string fields in the JSON schema
([#1398](#1398)).
* Fix variable overrides in targets for non-string variables
([#1397](#1397)).
* Fix bundle schema for variables
([#1396](#1396)).
* Fix bundle documentation URL
([#1399](#1399)).

Internal:
* Removed autogenerated docs for the CLI commands
([#1392](#1392)).
* Remove `JSON.parse` call from homebrew-tap action
([#1393](#1393)).
* Ensure that Python dependencies are installed during upgrade
([#1390](#1390)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietern pietern pietern approved these changes

@andrewnester andrewnester Awaiting requested review from andrewnester

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shreyas-goenka @pietern