Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enum support for bundle templates #668

Merged
merged 18 commits into from
Sep 8, 2023
Merged

Add enum support for bundle templates #668

merged 18 commits into from
Sep 8, 2023

Conversation

shreyas-goenka
Copy link
Contributor

@shreyas-goenka shreyas-goenka commented Aug 15, 2023 •
edited
Loading

Changes

This PR includes:

  1. Adding enum field to the json schema struct
  2. Adding prompting logic for enum values. See demo for how it looks
  3. Validation rules, validating the default value and config values when an enum list is specified

This will now enable template authors to use enums for input parameters.

Tests

Manually and new unit tests

@shreyas-goenka shreyas-goenka marked this pull request as ready for review August 16, 2023 09:11
pietern
pietern reviewed Aug 16, 2023
View reviewed changes
libs/cmdio/logger.go Outdated Show resolved Hide resolved
libs/jsonschema/schema.go Show resolved Hide resolved
libs/cmdio/logger.go Outdated Show resolved Hide resolved
@shreyas-goenka
Copy link
Contributor Author

demo:

Screen.Recording.2023-08-16.at.4.18.08.PM.mov

andrewnester
andrewnester reviewed Aug 16, 2023
View reviewed changes
libs/cmdio/logger.go Show resolved Hide resolved
libs/template/config.go Outdated Show resolved Hide resolved
@shreyas-goenka
Copy link
Contributor Author

Verified manually that the enum prompt UI still works similar to the earlier video,

@shreyas-goenka shreyas-goenka mentioned this pull request Sep 6, 2023
Merged
@shreyas-goenka
Copy link
Contributor Author

Tested manually, the prompt UI still works.

pietern
pietern approved these changes Sep 8, 2023
View reviewed changes
libs/cmdio/logger.go Show resolved Hide resolved
libs/jsonschema/instance.go Outdated Show resolved Hide resolved
libs/jsonschema/testdata/schema-load-int/schema-invalid-enum.json Show resolved Hide resolved
@shreyas-goenka shreyas-goenka added this pull request to the merge queue Sep 8, 2023
Merged via the queue into main with commit 7c96270 Sep 8, 2023
4 checks passed
@shreyas-goenka shreyas-goenka deleted the add-template-enums branch September 8, 2023 12:12
pietern added a commit that referenced this pull request Sep 11, 2023
@pietern
Release v0.204.1
b668c64 
Bundles:
 * Fix conversion of job parameters ([#744](#744)).
 * Add schema and config validation to jsonschema package ([#740](#740)).
 * Support Model Serving Endpoints in bundles ([#682](#682)).
 * Do not include empty output in job run output ([#749](#749)).
 * Fixed marking libraries from DBFS as remote ([#750](#750)).
 * Process only Python wheel tasks which have local libraries used ([#751](#751)).
 * Add enum support for bundle templates ([#668](#668)).
 * Apply Python wheel trampoline if workspace library is used ([#755](#755)).
 * List available targets when incorrect target passed ([#756](#756)).
 * Make bundle and sync fields optional ([#757](#757)).
 * Consolidate environment variable interaction ([#747](#747)).

Internal:
 * Update Go SDK to v0.19.1 ([#759](#759)).
@pietern pietern mentioned this pull request Sep 11, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 11, 2023
@pietern
Release v0.204.1 (#763)
44726d6 
Bundles:
* Fix conversion of job parameters
([#744](#744)).
* Add schema and config validation to jsonschema package
([#740](#740)).
* Support Model Serving Endpoints in bundles
([#682](#682)).
* Do not include empty output in job run output
([#749](#749)).
* Fixed marking libraries from DBFS as remote
([#750](#750)).
* Process only Python wheel tasks which have local libraries used
([#751](#751)).
* Add enum support for bundle templates
([#668](#668)).
* Apply Python wheel trampoline if workspace library is used
([#755](#755)).
* List available targets when incorrect target passed
([#756](#756)).
* Make bundle and sync fields optional
([#757](#757)).
* Consolidate environment variable interaction
([#747](#747)).

Internal:
* Update Go SDK to v0.19.1
([#759](#759)).
hectorcast-db pushed a commit that referenced this pull request Oct 13, 2023
@pietern @hectorcast-db
Release v0.204.1 (#763)
c05231c 
Bundles:
* Fix conversion of job parameters
([#744](#744)).
* Add schema and config validation to jsonschema package
([#740](#740)).
* Support Model Serving Endpoints in bundles
([#682](#682)).
* Do not include empty output in job run output
([#749](#749)).
* Fixed marking libraries from DBFS as remote
([#750](#750)).
* Process only Python wheel tasks which have local libraries used
([#751](#751)).
* Add enum support for bundle templates
([#668](#668)).
* Apply Python wheel trampoline if workspace library is used
([#755](#755)).
* List available targets when incorrect target passed
([#756](#756)).
* Make bundle and sync fields optional
([#757](#757)).
* Consolidate environment variable interaction
([#747](#747)).

Internal:
* Update Go SDK to v0.19.1
([#759](#759)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietern pietern pietern approved these changes

@andrewnester andrewnester Awaiting requested review from andrewnester

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shreyas-goenka @pietern @andrewnester