Support Model Serving Endpoints in bundles #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-goenka
approved these changes
Sep 4, 2023
pietern
requested changes
Sep 4, 2023
There was a problem hiding this comment.
Thanks, @arpitjasa-db !
The approach LGTM. I'd like to figure out naming consistency before we merge.
|
Confirmed it works as expected here: https://github.com/databricks/bundle-examples-internal/pull/76 |
pietern
approved these changes
Sep 7, 2023
pietern
changed the title
pietern
changed the title
lennartkats-db
approved these changes
Sep 7, 2023
auto-merge was automatically disabled
September 7, 2023 20:22
Head branch was pushed to by a user without write access
arpitjasa-db
force-pushed
the
serving
branch
3 times, most recently
from
61ee2b1
to
d1a9bfc
Compare
pietern
approved these changes
Sep 7, 2023
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> update descriptions Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> Fix permissions Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> Fix test Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> Add test coverage Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> Update name and add tests Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> Update test Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> Fix test Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> Add name check to test and fix target Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> Fix test Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> Update convert_test.go Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> Fix nit Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> Update prefix Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
auto-merge was automatically disabled
September 7, 2023 21:48
Head branch was pushed to by a user without write access
arpitjasa-db
force-pushed
the
serving
branch
from
d1a9bfc
to
6371364
Compare
pietern
added a commit
that referenced
this pull request
Sep 11, 2023
Bundles: * Fix conversion of job parameters ([#744](#744)). * Add schema and config validation to jsonschema package ([#740](#740)). * Support Model Serving Endpoints in bundles ([#682](#682)). * Do not include empty output in job run output ([#749](#749)). * Fixed marking libraries from DBFS as remote ([#750](#750)). * Process only Python wheel tasks which have local libraries used ([#751](#751)). * Add enum support for bundle templates ([#668](#668)). * Apply Python wheel trampoline if workspace library is used ([#755](#755)). * List available targets when incorrect target passed ([#756](#756)). * Make bundle and sync fields optional ([#757](#757)). * Consolidate environment variable interaction ([#747](#747)). Internal: * Update Go SDK to v0.19.1 ([#759](#759)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 11, 2023
Bundles: * Fix conversion of job parameters ([#744](#744)). * Add schema and config validation to jsonschema package ([#740](#740)). * Support Model Serving Endpoints in bundles ([#682](#682)). * Do not include empty output in job run output ([#749](#749)). * Fixed marking libraries from DBFS as remote ([#750](#750)). * Process only Python wheel tasks which have local libraries used ([#751](#751)). * Add enum support for bundle templates ([#668](#668)). * Apply Python wheel trampoline if workspace library is used ([#755](#755)). * List available targets when incorrect target passed ([#756](#756)). * Make bundle and sync fields optional ([#757](#757)). * Consolidate environment variable interaction ([#747](#747)). Internal: * Update Go SDK to v0.19.1 ([#759](#759)).
hectorcast-db
pushed a commit
that referenced
this pull request
Oct 13, 2023
Bundles: * Fix conversion of job parameters ([#744](#744)). * Add schema and config validation to jsonschema package ([#740](#740)). * Support Model Serving Endpoints in bundles ([#682](#682)). * Do not include empty output in job run output ([#749](#749)). * Fixed marking libraries from DBFS as remote ([#750](#750)). * Process only Python wheel tasks which have local libraries used ([#751](#751)). * Add enum support for bundle templates ([#668](#668)). * Apply Python wheel trampoline if workspace library is used ([#755](#755)). * List available targets when incorrect target passed ([#756](#756)). * Make bundle and sync fields optional ([#757](#757)). * Consolidate environment variable interaction ([#747](#747)). Internal: * Update Go SDK to v0.19.1 ([#759](#759)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add Model Serving Endpoints to Databricks Bundles
Tests
Unit tests and manual testing via https://github.com/databricks/bundle-examples-internal/pull/76
