Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include empty output in job run output #749

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

andrewnester
Copy link
Contributor

Changes

Do not include empty output in job run output

Tests

Running a job from CLI, the result:

andrew.nester@HFW9Y94129 wheel % databricks bundle run some_other_job --output json
Run URL: https://***/?o=6051921418418893#job/780620378804085/run/386695528477456

2023-09-08 11:33:24 "[default] My Wheel Job" TERMINATED SUCCESS 
{
  "task_outputs": [
    {
      "TaskKey": "TestTask",
      "Output": {
        "result": "Hello from my func\nGot arguments v2:\n['python']\n"
      },
      "EndTime": 1694165597474
    }
  ]

Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you take a look at the JSON structure of this output as well?

With task keys being unique, I think we can emit a JSON object like:

{
  "run_id": 123,
  "tasks": {
    "TaskKey": {
      "run_id": 456,
      "end_time": 123,
      "output": {
        //...
      },
    },
  },
}

@shreyas-goenka I suspect the origin of emitting an array has to do with how this is presented in text output mode, correct? There it is ordered by the end time of a task such that the output is sequential w.r.t. the execution time.

@andrewnester andrewnester added this pull request to the merge queue Sep 8, 2023
Merged via the queue into main with commit e08f419 Sep 8, 2023
4 checks passed
@andrewnester andrewnester deleted the fix-job-json-output branch September 8, 2023 09:58
pietern added a commit that referenced this pull request Sep 11, 2023
Bundles:
 * Fix conversion of job parameters ([#744](#744)).
 * Add schema and config validation to jsonschema package ([#740](#740)).
 * Support Model Serving Endpoints in bundles ([#682](#682)).
 * Do not include empty output in job run output ([#749](#749)).
 * Fixed marking libraries from DBFS as remote ([#750](#750)).
 * Process only Python wheel tasks which have local libraries used ([#751](#751)).
 * Add enum support for bundle templates ([#668](#668)).
 * Apply Python wheel trampoline if workspace library is used ([#755](#755)).
 * List available targets when incorrect target passed ([#756](#756)).
 * Make bundle and sync fields optional ([#757](#757)).
 * Consolidate environment variable interaction ([#747](#747)).

Internal:
 * Update Go SDK to v0.19.1 ([#759](#759)).
@pietern pietern mentioned this pull request Sep 11, 2023
github-merge-queue bot pushed a commit that referenced this pull request Sep 11, 2023
Bundles:
* Fix conversion of job parameters
([#744](#744)).
* Add schema and config validation to jsonschema package
([#740](#740)).
* Support Model Serving Endpoints in bundles
([#682](#682)).
* Do not include empty output in job run output
([#749](#749)).
* Fixed marking libraries from DBFS as remote
([#750](#750)).
* Process only Python wheel tasks which have local libraries used
([#751](#751)).
* Add enum support for bundle templates
([#668](#668)).
* Apply Python wheel trampoline if workspace library is used
([#755](#755)).
* List available targets when incorrect target passed
([#756](#756)).
* Make bundle and sync fields optional
([#757](#757)).
* Consolidate environment variable interaction
([#747](#747)).

Internal:
* Update Go SDK to v0.19.1
([#759](#759)).
hectorcast-db pushed a commit that referenced this pull request Oct 13, 2023
Bundles:
* Fix conversion of job parameters
([#744](#744)).
* Add schema and config validation to jsonschema package
([#740](#740)).
* Support Model Serving Endpoints in bundles
([#682](#682)).
* Do not include empty output in job run output
([#749](#749)).
* Fixed marking libraries from DBFS as remote
([#750](#750)).
* Process only Python wheel tasks which have local libraries used
([#751](#751)).
* Add enum support for bundle templates
([#668](#668)).
* Apply Python wheel trampoline if workspace library is used
([#755](#755)).
* List available targets when incorrect target passed
([#756](#756)).
* Make bundle and sync fields optional
([#757](#757)).
* Consolidate environment variable interaction
([#747](#747)).

Internal:
* Update Go SDK to v0.19.1
([#759](#759)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants