-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not include empty output in job run output #749
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you take a look at the JSON structure of this output as well?
With task keys being unique, I think we can emit a JSON object like:
{
"run_id": 123,
"tasks": {
"TaskKey": {
"run_id": 456,
"end_time": 123,
"output": {
//...
},
},
},
}
@shreyas-goenka I suspect the origin of emitting an array has to do with how this is presented in text output mode, correct? There it is ordered by the end time of a task such that the output is sequential w.r.t. the execution time.
Bundles: * Fix conversion of job parameters ([#744](#744)). * Add schema and config validation to jsonschema package ([#740](#740)). * Support Model Serving Endpoints in bundles ([#682](#682)). * Do not include empty output in job run output ([#749](#749)). * Fixed marking libraries from DBFS as remote ([#750](#750)). * Process only Python wheel tasks which have local libraries used ([#751](#751)). * Add enum support for bundle templates ([#668](#668)). * Apply Python wheel trampoline if workspace library is used ([#755](#755)). * List available targets when incorrect target passed ([#756](#756)). * Make bundle and sync fields optional ([#757](#757)). * Consolidate environment variable interaction ([#747](#747)). Internal: * Update Go SDK to v0.19.1 ([#759](#759)).
Bundles: * Fix conversion of job parameters ([#744](#744)). * Add schema and config validation to jsonschema package ([#740](#740)). * Support Model Serving Endpoints in bundles ([#682](#682)). * Do not include empty output in job run output ([#749](#749)). * Fixed marking libraries from DBFS as remote ([#750](#750)). * Process only Python wheel tasks which have local libraries used ([#751](#751)). * Add enum support for bundle templates ([#668](#668)). * Apply Python wheel trampoline if workspace library is used ([#755](#755)). * List available targets when incorrect target passed ([#756](#756)). * Make bundle and sync fields optional ([#757](#757)). * Consolidate environment variable interaction ([#747](#747)). Internal: * Update Go SDK to v0.19.1 ([#759](#759)).
Bundles: * Fix conversion of job parameters ([#744](#744)). * Add schema and config validation to jsonschema package ([#740](#740)). * Support Model Serving Endpoints in bundles ([#682](#682)). * Do not include empty output in job run output ([#749](#749)). * Fixed marking libraries from DBFS as remote ([#750](#750)). * Process only Python wheel tasks which have local libraries used ([#751](#751)). * Add enum support for bundle templates ([#668](#668)). * Apply Python wheel trampoline if workspace library is used ([#755](#755)). * List available targets when incorrect target passed ([#756](#756)). * Make bundle and sync fields optional ([#757](#757)). * Consolidate environment variable interaction ([#747](#747)). Internal: * Update Go SDK to v0.19.1 ([#759](#759)).
Changes
Do not include empty output in job run output
Tests
Running a job from CLI, the result: