Make a notebook wrapper for Python wheel tasks optional #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietern
reviewed
Sep 26, 2023
pietern
approved these changes
Sep 26, 2023
andrewnester
added a commit
that referenced
this pull request
Sep 27, 2023
Bundles: * Enable target overrides for pipeline clusters ([#792](#792)). * Add support for regex patterns in template schema ([#768](#768)). * Make the default `databricks bundle init` template more self-explanatory ([#796](#796)). * Make a notebook wrapper for Python wheel tasks optional ([#797](#797)). * Added a warning when Python wheel wrapper needs to be used ([#807](#807)). Internal: * Added `process.Background()` and `process.Forwarded()` ([#804](#804)). Dependency updates: * Bump golang.org/x/term from 0.11.0 to 0.12.0 ([#798](#798)). * Bump github.com/hashicorp/terraform-exec from 0.18.1 to 0.19.0 ([#801](#801)). * Bump golang.org/x/oauth2 from 0.11.0 to 0.12.0 ([#802](#802)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
Bundles: * Enable target overrides for pipeline clusters ([#792](#792)). * Add support for regex patterns in template schema ([#768](#768)). * Make the default `databricks bundle init` template more self-explanatory ([#796](#796)). * Make a notebook wrapper for Python wheel tasks optional ([#797](#797)). * Added a warning when Python wheel wrapper needs to be used ([#807](#807)). Internal: * Added `process.Background()` and `process.Forwarded()` ([#804](#804)). Dependency updates: * Bump golang.org/x/term from 0.11.0 to 0.12.0 ([#798](#798)). * Bump github.com/hashicorp/terraform-exec from 0.18.1 to 0.19.0 ([#801](#801)). * Bump golang.org/x/oauth2 from 0.11.0 to 0.12.0 ([#802](#802)).
hectorcast-db
pushed a commit
that referenced
this pull request
Oct 13, 2023
## Changes Instead of always using notebook wrapper for Python wheel tasks, let's make this an opt-in option. Now by default Python wheel tasks will be deployed as is to Databricks platform. If notebook wrapper required (DBR < 13.1 or other configuration differences), users can provide a following experimental setting ``` experimental: python_wheel_wrapper: true ``` Fixes #783, databricks/databricks-asset-bundles-dais2023#8 ## Tests Added unit tests. Integration tests passed for both cases ``` helpers.go:163: [databricks stdout]: Hello from my func helpers.go:163: [databricks stdout]: Got arguments: helpers.go:163: [databricks stdout]: ['my_test_code', 'one', 'two'] ... Bundle remote directory is ***/.bundle/ac05d5e8-ed4b-4e34-b3f2-afa73f62b021 Deleted snapshot file at /var/folders/nt/xjv68qzs45319w4k36dhpylc0000gp/T/TestAccPythonWheelTaskDeployAndRunWithWrapper3733431114/001/.databricks/bundle/default/sync-snapshots/cac1e02f3941a97b.json Successfully deleted files! --- PASS: TestAccPythonWheelTaskDeployAndRunWithWrapper (214.18s) PASS coverage: 93.5% of statements in ./... ok github.com/databricks/cli/internal/bundle 214.495s coverage: 93.5% of statements in ./... ``` ``` helpers.go:163: [databricks stdout]: Hello from my func helpers.go:163: [databricks stdout]: Got arguments: helpers.go:163: [databricks stdout]: ['my_test_code', 'one', 'two'] ... Bundle remote directory is ***/.bundle/0ef67aaf-5960-4049-bf1d-dc9e29157421 Deleted snapshot file at /var/folders/nt/xjv68qzs45319w4k36dhpylc0000gp/T/TestAccPythonWheelTaskDeployAndRunWithoutWrapper2340216760/001/.databricks/bundle/default/sync-snapshots/edf0b322cee93b13.json Successfully deleted files! --- PASS: TestAccPythonWheelTaskDeployAndRunWithoutWrapper (192.36s) PASS coverage: 93.5% of statements in ./... ok github.com/databricks/cli/internal/bundle 195.130s coverage: 93.5% of statements in ./... ```
hectorcast-db
pushed a commit
that referenced
this pull request
Oct 13, 2023
Bundles: * Enable target overrides for pipeline clusters ([#792](#792)). * Add support for regex patterns in template schema ([#768](#768)). * Make the default `databricks bundle init` template more self-explanatory ([#796](#796)). * Make a notebook wrapper for Python wheel tasks optional ([#797](#797)). * Added a warning when Python wheel wrapper needs to be used ([#807](#807)). Internal: * Added `process.Background()` and `process.Forwarded()` ([#804](#804)). Dependency updates: * Bump golang.org/x/term from 0.11.0 to 0.12.0 ([#798](#798)). * Bump github.com/hashicorp/terraform-exec from 0.18.1 to 0.19.0 ([#801](#801)). * Bump golang.org/x/oauth2 from 0.11.0 to 0.12.0 ([#802](#802)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Instead of always using notebook wrapper for Python wheel tasks, let's make this an opt-in option.
Now by default Python wheel tasks will be deployed as is to Databricks platform.
If notebook wrapper required (DBR < 13.1 or other configuration differences), users can provide a following experimental setting
Fixes #783, databricks/databricks-asset-bundles-dais2023#8
Tests
Added unit tests.
Integration tests passed for both cases