Added a warning when Python wheel wrapper needs to be used #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietern
reviewed
Sep 26, 2023
| PythonWheelTask: &jobs.PythonWheelTask{}, | ||
| JobClusterKey: "cluster1", | ||
| Libraries: []compute.Library{ | ||
| {Whl: "/Workspace/Users/me@me.com/dist/test.whl"}, |
There was a problem hiding this comment.
The test confirms that this should be fine and not trigger a warning.
Is this because it's an abs path and therefore we don't care about it?
There was a problem hiding this comment.
@pietern yes, exactly, we wouldn't not wrap it anyway so it should be skipped
pietern
approved these changes
Sep 27, 2023
| } | ||
|
|
||
| v := "v" + parts[0] + "." + parts[1] | ||
| return semver.Compare(v, "v13.1") < 0 |
There was a problem hiding this comment.
This depends on the data security mode, no?
There's 13.1 for assigned clusters and 13.2 for shared clusters.
This is good enough for now, though.
There was a problem hiding this comment.
@pietern it indeed depends on it but the error received in this case is pretty clear by itself and actionable by users anyway
andrewnester
added a commit
that referenced
this pull request
Sep 27, 2023
Bundles: * Enable target overrides for pipeline clusters ([#792](#792)). * Add support for regex patterns in template schema ([#768](#768)). * Make the default `databricks bundle init` template more self-explanatory ([#796](#796)). * Make a notebook wrapper for Python wheel tasks optional ([#797](#797)). * Added a warning when Python wheel wrapper needs to be used ([#807](#807)). Internal: * Added `process.Background()` and `process.Forwarded()` ([#804](#804)). Dependency updates: * Bump golang.org/x/term from 0.11.0 to 0.12.0 ([#798](#798)). * Bump github.com/hashicorp/terraform-exec from 0.18.1 to 0.19.0 ([#801](#801)). * Bump golang.org/x/oauth2 from 0.11.0 to 0.12.0 ([#802](#802)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
Bundles: * Enable target overrides for pipeline clusters ([#792](#792)). * Add support for regex patterns in template schema ([#768](#768)). * Make the default `databricks bundle init` template more self-explanatory ([#796](#796)). * Make a notebook wrapper for Python wheel tasks optional ([#797](#797)). * Added a warning when Python wheel wrapper needs to be used ([#807](#807)). Internal: * Added `process.Background()` and `process.Forwarded()` ([#804](#804)). Dependency updates: * Bump golang.org/x/term from 0.11.0 to 0.12.0 ([#798](#798)). * Bump github.com/hashicorp/terraform-exec from 0.18.1 to 0.19.0 ([#801](#801)). * Bump golang.org/x/oauth2 from 0.11.0 to 0.12.0 ([#802](#802)).
hectorcast-db
pushed a commit
that referenced
this pull request
Oct 13, 2023
## Changes Added a warning when Python wheel wrapper needs to be used ## Tests Added unit tests + manual run with different bundle configurations
hectorcast-db
pushed a commit
that referenced
this pull request
Oct 13, 2023
Bundles: * Enable target overrides for pipeline clusters ([#792](#792)). * Add support for regex patterns in template schema ([#768](#768)). * Make the default `databricks bundle init` template more self-explanatory ([#796](#796)). * Make a notebook wrapper for Python wheel tasks optional ([#797](#797)). * Added a warning when Python wheel wrapper needs to be used ([#807](#807)). Internal: * Added `process.Background()` and `process.Forwarded()` ([#804](#804)). Dependency updates: * Bump golang.org/x/term from 0.11.0 to 0.12.0 ([#798](#798)). * Bump github.com/hashicorp/terraform-exec from 0.18.1 to 0.19.0 ([#801](#801)). * Bump golang.org/x/oauth2 from 0.11.0 to 0.12.0 ([#802](#802)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added a warning when Python wheel wrapper needs to be used
Tests
Added unit tests + manual run with different bundle configurations