Added process.Background() and process.Forwarded()
#804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds higher-level wrappers for calling subprocesses
pietern
reviewed
Sep 26, 2023
pietern
reviewed
Sep 26, 2023
pietern
reviewed
Sep 27, 2023
pietern
approved these changes
Sep 27, 2023
andrewnester
approved these changes
Sep 27, 2023
andrewnester
added a commit
that referenced
this pull request
Sep 27, 2023
Bundles: * Enable target overrides for pipeline clusters ([#792](#792)). * Add support for regex patterns in template schema ([#768](#768)). * Make the default `databricks bundle init` template more self-explanatory ([#796](#796)). * Make a notebook wrapper for Python wheel tasks optional ([#797](#797)). * Added a warning when Python wheel wrapper needs to be used ([#807](#807)). Internal: * Added `process.Background()` and `process.Forwarded()` ([#804](#804)). Dependency updates: * Bump golang.org/x/term from 0.11.0 to 0.12.0 ([#798](#798)). * Bump github.com/hashicorp/terraform-exec from 0.18.1 to 0.19.0 ([#801](#801)). * Bump golang.org/x/oauth2 from 0.11.0 to 0.12.0 ([#802](#802)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
Bundles: * Enable target overrides for pipeline clusters ([#792](#792)). * Add support for regex patterns in template schema ([#768](#768)). * Make the default `databricks bundle init` template more self-explanatory ([#796](#796)). * Make a notebook wrapper for Python wheel tasks optional ([#797](#797)). * Added a warning when Python wheel wrapper needs to be used ([#807](#807)). Internal: * Added `process.Background()` and `process.Forwarded()` ([#804](#804)). Dependency updates: * Bump golang.org/x/term from 0.11.0 to 0.12.0 ([#798](#798)). * Bump github.com/hashicorp/terraform-exec from 0.18.1 to 0.19.0 ([#801](#801)). * Bump golang.org/x/oauth2 from 0.11.0 to 0.12.0 ([#802](#802)).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 3, 2023
This PR adds a few utilities related to Python interpreter detection:
- `python.DetectInterpreters` to detect all Python versions available in
`$PATH` by executing every matched binary name with `--version` flag.
- `python.DetectVirtualEnvPath` to detect if there's any child virtual
environment in `src` directory
- `python.DetectExecutable` to detect if there's python3 installed
either by `which python3` command or by calling
`python.DetectInterpreters().AtLeast("v3.8")`
To be merged after #804, as one of
the steps to get #637 in, as
previously discussed.
hectorcast-db
pushed a commit
that referenced
this pull request
Oct 13, 2023
## Changes This PR adds higher-level wrappers for calling subprocesses. One of the steps to get #637 in, as previously discussed. The reason to add `process.Forwarded()` is to proxy Python's `input()` calls from a child process seamlessly. Another use-case is plugging in `less` as a pager for the list results. ## Tests `make test`
hectorcast-db
pushed a commit
that referenced
this pull request
Oct 13, 2023
Bundles: * Enable target overrides for pipeline clusters ([#792](#792)). * Add support for regex patterns in template schema ([#768](#768)). * Make the default `databricks bundle init` template more self-explanatory ([#796](#796)). * Make a notebook wrapper for Python wheel tasks optional ([#797](#797)). * Added a warning when Python wheel wrapper needs to be used ([#807](#807)). Internal: * Added `process.Background()` and `process.Forwarded()` ([#804](#804)). Dependency updates: * Bump golang.org/x/term from 0.11.0 to 0.12.0 ([#798](#798)). * Bump github.com/hashicorp/terraform-exec from 0.18.1 to 0.19.0 ([#801](#801)). * Bump golang.org/x/oauth2 from 0.11.0 to 0.12.0 ([#802](#802)).
hectorcast-db
pushed a commit
that referenced
this pull request
Oct 13, 2023
This PR adds a few utilities related to Python interpreter detection:
- `python.DetectInterpreters` to detect all Python versions available in
`$PATH` by executing every matched binary name with `--version` flag.
- `python.DetectVirtualEnvPath` to detect if there's any child virtual
environment in `src` directory
- `python.DetectExecutable` to detect if there's python3 installed
either by `which python3` command or by calling
`python.DetectInterpreters().AtLeast("v3.8")`
To be merged after #804, as one of
the steps to get #637 in, as
previously discussed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds higher-level wrappers for calling subprocesses. One of the steps to get #637 in, as previously discussed.
The reason to add
process.Forwarded()is to proxy Python'sinput()calls from a child process seamlessly. Another use-case is plugging inlessas a pager for the list results.Tests
make test