Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporter: fix rare race condition with variables map #3568

Merged
merged 1 commit into from
May 14, 2024

Conversation

alexott
Copy link
Contributor

@alexott alexott commented May 13, 2024

Changes

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@alexott alexott requested review from a team as code owners May 13, 2024 13:36
@alexott alexott requested review from tanmay-db and removed request for a team May 13, 2024 13:36
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.64%. Comparing base (76a2d61) to head (b99a1b0).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3568   +/-   ##
=======================================
  Coverage   82.64%   82.64%           
=======================================
  Files         184      184           
  Lines       19041    19043    +2     
=======================================
+ Hits        15737    15739    +2     
  Misses       2384     2384           
  Partials      920      920           
Files Coverage Δ
exporter/context.go 82.94% <100.00%> (+0.02%) ⬆️

@alexott alexott added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit 9fa3e1c May 14, 2024
5 checks passed
@alexott alexott deleted the exporter-variables-race-cond branch May 14, 2024 12:08
mgyucht added a commit that referenced this pull request May 14, 2024
### New Features and Improvements
* Add owner support to `databricks_sql_table` ([#3570](#3570)).
* Add `databricks_catalog` data source ([#3573](#3573)).
* Add `databricks_table` data source ([#3571](#3571)).
* Add `databricks_mlflow_experiment` data source ([#2389](#2389)).

### Documentation Changes

### Exporter
* Fix rare race condition with variables map ([#3568](#3568)).

### Internal Changes

Dependency updates:

 * Bump go SDK to 0.40.1 ([#3574](#3574)), featuring improvements in tracing and debuggability of failed requests.
@mgyucht mgyucht mentioned this pull request May 14, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 15, 2024
### New Features and Improvements
* Add owner support to `databricks_sql_table` ([#3570](#3570)).
* Add `databricks_catalog` data source ([#3573](#3573)).
* Add `databricks_table` data source ([#3571](#3571)).
* Add `databricks_mlflow_experiment` data source ([#2389](#2389)).

### Documentation Changes

### Exporter
* Fix rare race condition with variables map ([#3568](#3568)).

### Internal Changes

Dependency updates:

 * Bump go SDK to 0.40.1 ([#3574](#3574)), featuring improvements in tracing and debuggability of failed requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants