Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add databricks_table data source #3571

Merged
merged 3 commits into from
May 14, 2024
Merged

add databricks_table data source #3571

merged 3 commits into from
May 14, 2024

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented May 13, 2024

Changes

  • Add databricks_table data source. This should simplify use cases where customers need to retrieve a specific table for permissions granting & other purposes

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@nkvuong nkvuong requested review from a team as code owners May 13, 2024 18:30
@nkvuong nkvuong requested review from tanmay-db and removed request for a team May 13, 2024 18:30
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.57%. Comparing base (acb3700) to head (50d03a3).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3571      +/-   ##
==========================================
+ Coverage   82.55%   82.57%   +0.02%     
==========================================
  Files         184      185       +1     
  Lines       19077    19090      +13     
==========================================
+ Hits        15749    15764      +15     
+ Misses       2405     2404       -1     
+ Partials      923      922       -1     
Files Coverage Δ
catalog/data_table.go 100.00% <100.00%> (ø)
provider/provider.go 93.85% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to fix docs example...

docs/data-sources/table.md Outdated Show resolved Hide resolved
@nkvuong nkvuong added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit 6cfcb2b May 14, 2024
5 checks passed
@nkvuong nkvuong deleted the feature/data_table branch May 14, 2024 13:08
@alexott alexott mentioned this pull request May 14, 2024
5 tasks
@jdavidheiser
Copy link

thank you for pushing this over the finish line!

@nkvuong nkvuong linked an issue May 14, 2024 that may be closed by this pull request
mgyucht added a commit that referenced this pull request May 14, 2024
### New Features and Improvements
* Add owner support to `databricks_sql_table` ([#3570](#3570)).
* Add `databricks_catalog` data source ([#3573](#3573)).
* Add `databricks_table` data source ([#3571](#3571)).
* Add `databricks_mlflow_experiment` data source ([#2389](#2389)).

### Documentation Changes

### Exporter
* Fix rare race condition with variables map ([#3568](#3568)).

### Internal Changes

Dependency updates:

 * Bump go SDK to 0.40.1 ([#3574](#3574)), featuring improvements in tracing and debuggability of failed requests.
@mgyucht mgyucht mentioned this pull request May 14, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 15, 2024
### New Features and Improvements
* Add owner support to `databricks_sql_table` ([#3570](#3570)).
* Add `databricks_catalog` data source ([#3573](#3573)).
* Add `databricks_table` data source ([#3571](#3571)).
* Add `databricks_mlflow_experiment` data source ([#2389](#2389)).

### Documentation Changes

### Exporter
* Fix rare race condition with variables map ([#3568](#3568)).

### Internal Changes

Dependency updates:

 * Bump go SDK to 0.40.1 ([#3574](#3574)), featuring improvements in tracing and debuggability of failed requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add a databricks_sql_table data source
5 participants