Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added owner support to databricks_sql_table #3570

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented May 13, 2024

Changes

Resolves #3342

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@nkvuong nkvuong requested review from a team as code owners May 13, 2024 16:13
@nkvuong nkvuong requested review from hectorcast-db and removed request for a team May 13, 2024 16:13
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 51.85185% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 82.51%. Comparing base (acb3700) to head (08c5fb0).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3570      +/-   ##
==========================================
- Coverage   82.55%   82.51%   -0.05%     
==========================================
  Files         184      184              
  Lines       19077    19103      +26     
==========================================
+ Hits        15749    15762      +13     
- Misses       2405     2413       +8     
- Partials      923      928       +5     
Files Coverage Δ
catalog/resource_sql_table.go 89.03% <51.85%> (-2.78%) ⬇️

@nkvuong
Copy link
Contributor Author

nkvuong commented May 13, 2024

integration tests passed, failures are not related

@alexott alexott added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit 6232f01 May 14, 2024
5 checks passed
@alexott alexott deleted the feature/sql_table_owner branch May 14, 2024 12:10
mgyucht added a commit that referenced this pull request May 14, 2024
### New Features and Improvements
* Add owner support to `databricks_sql_table` ([#3570](#3570)).
* Add `databricks_catalog` data source ([#3573](#3573)).
* Add `databricks_table` data source ([#3571](#3571)).
* Add `databricks_mlflow_experiment` data source ([#2389](#2389)).

### Documentation Changes

### Exporter
* Fix rare race condition with variables map ([#3568](#3568)).

### Internal Changes

Dependency updates:

 * Bump go SDK to 0.40.1 ([#3574](#3574)), featuring improvements in tracing and debuggability of failed requests.
@mgyucht mgyucht mentioned this pull request May 14, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 15, 2024
### New Features and Improvements
* Add owner support to `databricks_sql_table` ([#3570](#3570)).
* Add `databricks_catalog` data source ([#3573](#3573)).
* Add `databricks_table` data source ([#3571](#3571)).
* Add `databricks_mlflow_experiment` data source ([#2389](#2389)).

### Documentation Changes

### Exporter
* Fix rare race condition with variables map ([#3568](#3568)).

### Internal Changes

Dependency updates:

 * Bump go SDK to 0.40.1 ([#3574](#3574)), featuring improvements in tracing and debuggability of failed requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support setting table owner in databricks_sql_table resource
4 participants