Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding lookback stats summaries and test #14

Merged
merged 5 commits into from
Sep 28, 2020
Merged

Conversation

rportilla-databricks
Copy link
Contributor

Please review new summary lookback stats.

Copy link
Contributor

@tnixon tnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't be committing egg-info files into the repo (these are generated by build process). The git-ignore ought to be filtering these out, but it looks like you're building the package named 'tca' not 'tempo' (so git-ignore patterns won't catch this). Please try merging in latest changes from master into your branch and re-push.

Copy link
Contributor

@tnixon tnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to update git-ignore with some patterns for filtering out .pyc files and pycache dirs, too.

@tnixon tnixon self-requested a review September 28, 2020 21:39
tempo/tsdf.py Show resolved Hide resolved
@tnixon tnixon self-requested a review September 28, 2020 21:56
@tnixon tnixon merged commit b67e74d into master Sep 28, 2020
@tnixon tnixon deleted the tempo_lkback_smry_stats branch September 28, 2020 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants