Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

withRangeStats references hard-coded #16

Closed
tnixon opened this issue Sep 28, 2020 · 0 comments · Fixed by #17
Closed

withRangeStats references hard-coded #16

tnixon opened this issue Sep 28, 2020 · 0 comments · Fixed by #17
Assignees
@tnixon
Labels
bug Something isn't working

Comments

@tnixon
Copy link
Contributor

tnixon commented Sep 28, 2020

Noticed something I missed in the review for PR #14 -
there are 2 hardcoded references to the timeseries column name "EVENT_TS":

  1. line 187 in the construction of the Window
  2. line 198 in the filter on the columns to summarize
@tnixon tnixon added the bug Something isn't working label Sep 28, 2020
@tnixon tnixon self-assigned this Sep 28, 2020
tnixon added a commit that referenced this issue Sep 28, 2020
@tnixon
Fixing issue #16: should not use hardcoded column name references
c77d057
@tnixon tnixon mentioned this issue Sep 28, 2020
Merged
@tnixon tnixon linked a pull request Sep 28, 2020 that will close this issue
Fix wrs #17
Merged
rportilla-databricks pushed a commit that referenced this issue Sep 29, 2020
@tnixon
Fix wrs (#17)
61c722d 
* Fixing issue #16: should not use hardcoded column name references

* need to explicitly set the ts column name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tnixon tnixon

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix wrs databrickslabs/tempo
1 participant
@tnixon