Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ep3: Wrong file name data/sudoku.jpg #248

Closed
gcapes opened this issue Feb 8, 2023 · 5 comments · Fixed by #253
Closed

Ep3: Wrong file name data/sudoku.jpg #248

gcapes opened this issue Feb 8, 2023 · 5 comments · Fixed by #253
Assignees
@uschille @Kd-Here
Labels
bug good first issue Good issue for first-time contributors help wanted Looking for Contributors status:in progress Contributor working on issue

Comments

@gcapes
Copy link

gcapes commented Feb 8, 2023 •
edited
Loading

This file is actually data/sudoku.png
The solution text has the wrong extension.
@tobyhodges
Copy link
Member

Another small error in this exercise: the solution code block imports imageio with

import imageio.v3

but then refers to it as iio.

The solution should be updated to correct the file extension and add as iio to the end of the import statement.

@tobyhodges tobyhodges added help wanted Looking for Contributors good first issue Good issue for first-time contributors bug labels Feb 9, 2023
@mkcor
Copy link
Contributor

mkcor commented Feb 9, 2023

@gcapes would you like to submit a pull request with these small fixes? Thanks again for reporting!

@Kd-Here
Copy link

Kd-Here commented Feb 15, 2023

Can I work on this small fixes?

@tobyhodges
Copy link
Member

Yes please @Kd-Here

@mkcor
Copy link
Contributor

mkcor commented Feb 22, 2023

@Kd-Here are you comfortable creating a pull request to submit these small fixes? Don't hesitate to ask for help if you run into roadblocks!

@uschille uschille mentioned this issue Mar 5, 2023
Closed
3 tasks
@uschille uschille added the status:in progress Contributor working on issue label Mar 11, 2023
@uschille uschille mentioned this issue Mar 11, 2023
Merged
@uschille uschille linked a pull request Mar 11, 2023 that will close this issue
Convert sudokupng image to pure rgb without alpha channel #253
Merged
@uschille uschille self-assigned this Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uschille uschille

@Kd-Here Kd-Here

Labels
bug good first issue Good issue for first-time contributors help wanted Looking for Contributors status:in progress Contributor working on issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert sudokupng image to pure rgb without alpha channel datacarpentry/image-processing
5 participants
@mkcor @uschille @tobyhodges @gcapes @Kd-Here