Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carpentries Workbench Transition #268

Closed
zkamvar opened this issue Apr 14, 2023 · 22 comments
Closed

Carpentries Workbench Transition #268

zkamvar opened this issue Apr 14, 2023 · 22 comments
Labels
type:template and tools Issue about template and tools

Comments

@zkamvar
Copy link
Contributor

zkamvar commented Apr 14, 2023

Thank you for participating in the early transition to The Workbench. I have been able to render a preview of your lesson at https://fishtree-attempt.github.io/image-processing.

I am tracking issues for your lesson in carpentries/lesson-transition#46. I will be updating the preview next week as I work on any remaining issues.

Please inspect the preview and make note in carpentries/lesson-transition#46 if you see anything that needs to be fixed (e.g extra templating, narrow tables, or malformed text).

@zkamvar
Copy link
Contributor Author

zkamvar commented Apr 14, 2023

My apologies, there is some sort of glitch in my conversion tool and the repository never uploaded.

The glitch has been fixed and the lesson should be up in a few minutes. It turned out that the submodule was not on a branch for me.

@zkamvar
Copy link
Contributor Author

zkamvar commented Apr 25, 2023

This lesson will be converted to use The Carpentries Workbench
To prevent accidental reversion of the changes, we are temporarily revoking
write access for all collaborators on this lesson:

If you no longer wish to have write access to this repository, you do not
need to do anything further.

  1. What you can expect from the transition 📹: https://carpentries.github.io/workbench/beta-phase.html#beta
  2. How to update your local clone 💻: https://carpentries.github.io/workbench/beta-phase.html#updating-clone
  3. How to update (delete) your fork (if you have one) 📹: https://carpentries.github.io/workbench/faq.html#update-fork-from-styles

If you wish to regain write access, please re-clone the repository on your machine and
then comment here with I am ready for write access :rocket: and the
admin maintainer of this repository will restore your permissions.

If you have any questions, please reply here and tag @zkamvar

@zkamvar
Copy link
Contributor Author

zkamvar commented Apr 25, 2023

stand by. I am having technical difficulties with network issues

This has been fixed and came down to an unexpected network timeout see carpentries/lesson-transition#46 (comment) for details

@zkamvar
Copy link
Contributor Author

zkamvar commented Apr 25, 2023

The deed is done. The infrastructure takes a few minutes to bootstrap and cache the packages for the lesson build. Once the build is done, I will switch github pages to deploy from the gh-pages branch and you will have your workbench lesson.

Thank you all for your enthusiasm and your patience!

@zkamvar
Copy link
Contributor Author

zkamvar commented Apr 25, 2023

The Workbench version is now live: https://datacarpentry.github.io/image-processing/

In addition, here is map of commits that were changed during the transition

@uschille
Copy link
Contributor

I am ready for write access 🚀

I have updated my local clone and the forks at Clemson-MSE/image-processing and uschille/image-processing.

Thank you @zkamvar!!! ⭐

@zkamvar
Copy link
Contributor Author

zkamvar commented Apr 25, 2023

@uschille access granted!

@tobyhodges tobyhodges added the type:template and tools Issue about template and tools label Apr 26, 2023
@tobyhodges
Copy link
Member

The new lesson site looks great, @zkamvar, thank you.

@bobturneruk
Copy link
Contributor

I've archived my fork (I don't use it) and deleted my clone, so...

I am ready for write access 🚀

Thank you for the fantastic work @zkamvar

@zkamvar
Copy link
Contributor Author

zkamvar commented Apr 26, 2023

Access granted!

@bobturneruk
Copy link
Contributor

Thanks! I've somewhat lost track of all the changes, but the repository itself looks so tidy now. I really like it.

@zkamvar
Copy link
Contributor Author

zkamvar commented Apr 26, 2023

This might be of help: https://carpentries.github.io/workbench/transition-guide.html

This fix also has changed http -> https, fixed any inaccessible headings, and anything described in https://github.com/carpentries/lesson-transition/blob/main/datacarpentry/image-processing.R

@quist00
Copy link
Contributor

quist00 commented Apr 26, 2023

I also deleted my old copies and re-cloned the new repository. Is there anything else I need to do to be ready for write access?

@zkamvar
Copy link
Contributor Author

zkamvar commented Apr 26, 2023

I also deleted my old copies and re-cloned the new repository. Is there anything else I need to do to be ready for write access?

You must invoke the magic words:

If you wish to regain write access, please re-clone the repository on your machine and
then comment here with I am ready for write access :rocket: and the
admin maintainer of this repository will restore your permissions.

@quist00
Copy link
Contributor

quist00 commented Apr 26, 2023

Then make it so, lol. I am ready for write access.

@zkamvar
Copy link
Contributor Author

zkamvar commented Apr 26, 2023

Access granted! (because I am not a machine, I have granted access even though you were missing the 🚀 (@uschille saved you by adding the reaction 😝))

@quist00
Copy link
Contributor

quist00 commented Apr 26, 2023

Thanks! To infinity and beyond 😄

@zkamvar
Copy link
Contributor Author

zkamvar commented Apr 26, 2023

By Grabthar's hammer, what a lesson!

@uschille
Copy link
Contributor

I read through the log carpentries/lesson-transition#46 (comment) and could feel the sweating 😅. Awesome work!

@K-Meech
Copy link
Contributor

K-Meech commented Apr 27, 2023

I've updated my fork + local clone so -
I am ready for write access 🚀
Thanks @zkamvar !!

@zkamvar
Copy link
Contributor Author

zkamvar commented Apr 27, 2023

Granted!

@tobyhodges
Copy link
Member

As far as I can tell, all Maintainers have now had their access restored, so I am going to close this one. Thanks for all your help, @zkamvar - I am so happy to see this lesson with the new layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:template and tools Issue about template and tools
Projects
None yet
Development

No branches or pull requests

6 participants