Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feedback] Consider UI Treatment for admin area containment info #114

Closed
tjann opened this issue Jul 18, 2020 · 3 comments · Fixed by #163
Closed

[Feedback] Consider UI Treatment for admin area containment info #114

tjann opened this issue Jul 18, 2020 · 3 comments · Fixed by #163
Assignees
@shifucun
Labels
feature: browser feedback Feedback and suggestions for improvement P2

Comments

@tjann
Copy link
Contributor

tjann commented Jul 18, 2020

Feedback

Right now, browser randomly selects one of multiple typeOf to display. For states in the US, some are under "contained in place of Admin Area1", others are under "contained in place of State", yet others are under. "contained in place of Admin Area"

About

URL: https://browser.datacommons.org/kg?dcid=country/USA

Expected behavior

All under "State" or "AdminArea1", etc.

Screenshots

If applicable, add screenshots to help explain the issue or suggestion.

image
image
@tjann tjann added the feedback Feedback and suggestions for improvement label Jul 18, 2020
@pradh
Copy link
Contributor

pradh commented Jul 23, 2020

+1 (https://screenshot.googleplex.com/QSP1sxLv0Ao)

@shifucun shifucun self-assigned this Jul 23, 2020
@shifucun shifucun linked a pull request Jul 23, 2020 that will close this issue
Use all place types in contained in (child) place relation #163
Merged
@beets beets reopened this Jul 24, 2020
@beets
Copy link
Contributor

beets commented Jul 24, 2020

Reopening since there's ongoing discussion in #163 about ranking the contained types.

@shifucun shifucun added the P2 label Sep 17, 2021
@beets
Copy link
Contributor

beets commented Nov 8, 2021

fixed with the new browser

@beets beets closed this as completed Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shifucun shifucun

Labels
feature: browser feedback Feedback and suggestions for improvement P2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use all place types in contained in (child) place relation shifucun/website
4 participants
@pradh @shifucun @beets @tjann