-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dd-trace-rb 1.21.0 LoadError failures when running under a different user #3529
Comments
If you check the file permissions of the contents of 1.20.0 vs 1.21.0 gems you see that 1.21.0 seems to be missing world readable permissions on all files:
|
Manually adding the missing world readable permission works fine as a hotfix:
|
ivoanjo
added a commit
that referenced
this issue
Mar 18, 2024
**What does this PR do?** This PR adds validation so we catch the issue from #3529 before the incorrect packages are published on rubygems.org. Specifically, it checks that every file in packaged `.gem` file has the expected permissions. **Motivation:** Avoid #3529 happening again. **Additional Notes:** N/A **How to test the change?** You can run `bundle exec rake build` to trigger this validation. Try setting incorrect permissions on one of the files and running, and you should see the validation failing.
ivoanjo
added a commit
that referenced
this issue
Mar 18, 2024
**What does this PR do?** This PR adds validation so we catch the issue from #3529 before the incorrect packages are published on rubygems.org. Specifically, it checks that every file in packaged `.gem` file has the expected permissions. **Motivation:** Avoid #3529 happening again. **Additional Notes:** N/A **How to test the change?** You can run `bundle exec rake build` to trigger this validation. Try setting incorrect permissions on one of the files and running, and you should see the validation failing.
ivoanjo
added a commit
that referenced
this issue
Mar 18, 2024
**What does this PR do?** This PR adds validation so we catch the issue from #3529 before the incorrect packages are published on rubygems.org. Specifically, it checks that every file in packaged `.gem` file has the expected permissions. **Motivation:** Avoid #3529 happening again. **Additional Notes:** N/A **How to test the change?** You can run `bundle exec rake build` to trigger this validation. Try setting incorrect permissions on one of the files and running, and you should see the validation failing.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current behaviour
userA
).userB
).LoadError
errors are raised either duringddtracerb
/ddprofrb
execution or during requirement of a file included in the gem (such asrequire 'ddtrace/auto_instrument'
).Expected behaviour
Steps to reproduce
The text was updated successfully, but these errors were encountered: