Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for String conversions #23

Closed
coder-cooke opened this issue Mar 7, 2014 · 2 comments
Closed

Support for String conversions #23

coder-cooke opened this issue Mar 7, 2014 · 2 comments

Comments

@coder-cooke
Copy link
Contributor

Need the ability to convert from a string (eg. 'RUNNING') to a metric that we can alert on

I took a stab at adding this functionality. Can you review my approach and let me know if it's suitable for a Pull request.

coder-cooke@9aac3b5
@remh
Copy link
Contributor

remh commented Mar 7, 2014

Thanks!
The approach looks good to me.

There is some code cleaning that could be done in this part of the code (the existing one, not yours) though.

@coder-cooke coder-cooke mentioned this issue Mar 12, 2014
Merged
@remh
Copy link
Contributor

remh commented Mar 13, 2014

Closed by #26

@remh remh closed this as completed Mar 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coder-cooke @remh