Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect name for G1GC old generation JMX metric #230

Closed
dpratt opened this issue Jun 3, 2019 · 0 comments · Fixed by #231
Closed

Incorrect name for G1GC old generation JMX metric #230

dpratt opened this issue Jun 3, 2019 · 0 comments · Fixed by #231

Comments

@dpratt
Copy link
Contributor

dpratt commented Jun 3, 2019

The JMX metric name for collecting info on G1GC old generation counts and durations is incorrectly named. The default config file uses the name 'G1 Mixed Generation' when it should be 'G1 Old Generation'. I've confirmed this using visualvm on a running Java 8, 11 and 12 VM.

In the default config file (new-gc-default-jmx-metrics.yaml) the stanza at the bottom that reads

- include:
    domain: java.lang
    type: GarbageCollector
    name: G1 Mixed Generation
    attribute:
      CollectionCount:
        alias: jvm.gc.major_collection_count
        metric_type: counter
      CollectionTime:
        alias: jvm.gc.major_collection_time
        metric_type: counter

should be

- include:
    domain: java.lang
    type: GarbageCollector
    name: G1 Old Generation
    attribute:
      CollectionCount:
        alias: jvm.gc.major_collection_count
        metric_type: counter
      CollectionTime:
        alias: jvm.gc.major_collection_time
        metric_type: counter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant