Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generation throughput gradually ramps up #4

Closed
blt opened this issue Mar 10, 2021 · 0 comments · Fixed by #6
Closed

Generation throughput gradually ramps up #4

blt opened this issue Mar 10, 2021 · 0 comments · Fixed by #6

Comments

@blt
Copy link
Collaborator

blt commented Mar 10, 2021

Consider that the internal governor is generally left with a little bytes left over after each request as requests are made randomly between the maximum line size and 1. This is surprising -- it took me a minute to figure out -- and we might ought to have the algorithm be to request the maximum line size and then randomly use a portion of this only.
blt added a commit that referenced this issue Mar 10, 2021
@blt
Correct "bytes_written" telemetry
bfe0199 
Internal to file_gen's LogTarget is the notion of bytes_written, which is what
tracks progress toward the maximum file size of the target. Also there is a
bytes_written that is output as telemetry which really tracks the bytes filled
into the buffer, not the global size. Unfortunately because of name confusion I
got the whole mess confused and it looked like, from telemetry, that byte output
rate was getting faster and faster. Provably not accurate by looking at the
file.

Closes #4

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
@blt blt mentioned this issue Mar 10, 2021
Merged
@blt blt closed this as completed in #6 Mar 10, 2021
blt added a commit that referenced this issue Mar 10, 2021
@blt
Correct "bytes_written" telemetry (#6)
9e13b40 
Internal to file_gen's LogTarget is the notion of bytes_written, which is what
tracks progress toward the maximum file size of the target. Also there is a
bytes_written that is output as telemetry which really tracks the bytes filled
into the buffer, not the global size. Unfortunately because of name confusion I
got the whole mess confused and it looked like, from telemetry, that byte output
rate was getting faster and faster. Provably not accurate by looking at the
file.

Closes #4

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct "bytes_written" telemetry DataDog/lading
1 participant
@blt