Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Pasted Exception classes #32

Closed
derks opened this issue Jun 1, 2010 · 1 comment
Closed

Issues with Pasted Exception classes #32

derks opened this issue Jun 1, 2010 · 1 comment

Comments

@derks
Copy link
Member

derks commented Jun 1, 2010

Following issues were passed along via email:

    1) I believe that the project's generated Exception classes should be 
capitalized (in .../core/exc.py).   In fact, in the "default" method of the 
RootController class (in .../controllers/root.py), you raise an ArgumentError 
when no command is passed to the script.  The class name is correctly 
capitalized here but the class definitions are not.  (You may also want to 
check any other files that raise Exceptions:  After capitalizing all of the 
class names manually, I got an ImportError from .../core/appmain.py.  I didn't 
check anywhere else and changed that definitions back to the original.)

    2) Also in the Exception class definitions, the base Exception 
class(MyPyProject) should probably also have a __unicode__ method like:

   def __unicode__(self):
       return unicode(self.msg)

in case anyone is expecting/dealing with Unicode.
@derks
Copy link
Member Author

derks commented Jun 7, 2010

Resolved in master/0.8.3.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant