Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Introduction of FieldIndex and ColumnId types for clear differentiation of use #10017

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

lichuang
Copy link
Contributor

@lichuang lichuang commented Feb 13, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

refactor: Introduction of FieldIndex and ColumnId types for clear differentiation of use

Closes #9994

@lichuang lichuang requested a review from zhyass February 13, 2023 10:00
@vercel
Copy link

vercel bot commented Feb 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Feb 13, 2023 at 11:28AM (UTC)

@mergify mergify bot added the pr-refactor this PR changes the code base without new features or bugfix label Feb 13, 2023
Copy link
Member

@zhyass zhyass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichuang lichuang changed the title refactor: Introduction of ColumnIndex and ColumnId types for clear differentiation of use refactor: Introduction of FieldIndex and ColumnId types for clear differentiation of use Feb 13, 2023
@mergify mergify bot merged commit c5e494a into datafuselabs:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: Introduction of ColumnIndex and ColumnId types for clear differentiation of use
3 participants