Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix add column min\max stat bug #10137

Merged
merged 5 commits into from
Feb 21, 2023
Merged

fix: fix add column min\max stat bug #10137

merged 5 commits into from
Feb 21, 2023

Conversation

lichuang
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  1. fix: fix add column min\max stat bug
  2. unit test

Closes #10087

@vercel
Copy link

vercel bot commented Feb 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Feb 21, 2023 at 1:45AM (UTC)

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Feb 20, 2023
@BohuTANG BohuTANG added the ci-benchmark Benchmark: run all test label Feb 20, 2023
@github-actions
Copy link
Contributor

platform
Benchmark Results: https://repo.databend.rs/benchmark/clickbench/pr/10137/4223372100.html

zhyass
zhyass approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@zhyass zhyass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

platform
Benchmark Results: https://repo.databend.rs/benchmark/clickbench/pr/10137/4228467606.html

@mergify mergify bot merged commit 0e1f927 into databendlabs:main Feb 21, 2023
@lichuang lichuang deleted the snapshot_default_value branch February 21, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhyass zhyass zhyass approved these changes

@dantengsky dantengsky dantengsky approved these changes

Assignees
No one assigned
Labels
ci-benchmark Benchmark: run all test pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: snapshot.summary.col_stats wrong after add column
4 participants
@lichuang @dantengsky @zhyass @BohuTANG