Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix makefile: make run with build-release #4122

Merged
merged 2 commits into from
Feb 12, 2022

Conversation

Veeupup
Copy link
Collaborator

@Veeupup Veeupup commented Feb 12, 2022

Signed-off-by: Veeupup code@tanweime.com

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

fix bug in makefile with make run.

Changelog

  • Bug Fix

Related Issues

Fixes #issue

Test Plan

Unit Tests

Stateless Tests

Signed-off-by: Veeupup <code@tanweime.com>
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

2 similar comments
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot databend-bot added pr-bugfix this PR patches a bug in codebase need-review labels Feb 12, 2022
@vercel
Copy link

vercel bot commented Feb 12, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/AdXLh8SgQqD4Uh1PdwpCxF3jBweN
✅ Preview: Canceled

[Deployment for f90a1da canceled]

@BohuTANG
Copy link
Member

/lgtm

@BohuTANG
Copy link
Member

image

Thank you bot @Mergifyio

@codecov-commenter
Copy link

Codecov Report

Merging #4122 (f90a1da) into main (d6773b7) will increase coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4122   +/-   ##
=====================================
  Coverage     57%     57%           
=====================================
  Files        857     857           
  Lines      46183   46183           
=====================================
+ Hits       26633   26651   +18     
+ Misses     19550   19532   -18     
Impacted Files Coverage Δ
metasrv/src/meta_service/raftmeta.rs 49% <0%> (+<1%) ⬆️
common/ast/src/parser/expr/expr_visitor.rs 59% <0%> (+<1%) ⬆️
query/src/common/mod.rs 83% <0%> (+7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6773b7...f90a1da. Read the comment docs.

@mergify mergify bot merged commit 0055122 into datafuselabs:main Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants