Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate system tables with new processor #4166

Merged
merged 10 commits into from Feb 25, 2022

Conversation

zhang2014
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Integrate system tables with new processor

Changelog

  • New Feature

Related Issues

part #3931

Test Plan

Unit Tests

Stateless Tests

@vercel
Copy link

vercel bot commented Feb 16, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/5SwgDjcbg1X9o7FvzpJr4KXQfGPV
✅ Preview: https://databend-git-fork-zhang2014-systemtablesnewprocessor-databend.vercel.app

@mergify
Copy link
Contributor

mergify bot commented Feb 16, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Feb 16, 2022
# Conflicts:
#	query/src/pipelines/new/executor/executor_worker_context.rs
@zhang2014 zhang2014 marked this pull request as ready for review February 24, 2022 14:16
@zhang2014
Copy link
Member Author

after this pr. all system tables can work in the new processor framework.

@BohuTANG
Copy link
Member

/lgtm

@BohuTANG
Copy link
Member

BohuTANG commented Feb 25, 2022

after this pr. all system tables can work in the new processor framework.

Cool!
Seems many of the interpreter logic should be moved to a transform(or processor), then we can track and profile them under the new processor framework, not only the query interpreter.
For example: COPY, INSERT(... SELECT FROM) and DELETE etc, then we can visualize the profile easily.

@mergify mergify bot merged commit cd56f01 into datafuselabs:main Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants