-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support nullable group by #4340
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/databend/databend/FFe46UQMJwUEU4LL2gTvA6ZG1yJg |
Thanks for the contribution! Please review the labels and make any necessary changes. |
@@ -39,15 +73,40 @@ impl Series { | |||
/// Apply binary mode function to each element of the column. | |||
/// WARN: Can't use `&mut [Vec<u8>]` because it has performance drawback. | |||
/// Refer: https://github.com/rust-lang/rust-clippy/issues/8334 | |||
pub fn serialize(column: &ColumnRef, vec: &mut Vec<Vec<u8>>) -> Result<()> { | |||
/* | |||
* not nullable col1 nullable col2 (first byte to indicate null or not) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Ontime datasets benchmark (Both run on the second query with metacache): Before:
After:
|
Also cc @wubx @dantengsky for the performance improvement. It's time to change the subject/ontime table schema: |
C~l |
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Improve performance for
group by nullable column
Changelog
Related Issues
Continue: #4158
Fixes #4079
Test Plan
Unit Tests
Stateless Tests