Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump pprof again for musl 1.2.3 #6168

Merged
merged 4 commits into from
Jun 27, 2022
Merged

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Jun 23, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

After #6165, musl 1.2.3 is included in our build tools.

It is not possible to revert old commits as we have since modified them.

Changelog

  • Not for changelog (changelog entry is not required)

Related Issues

Fixes #issue

@vercel
Copy link

vercel bot commented Jun 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jun 27, 2022 at 8:16AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Jun 23, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@PsiACE PsiACE marked this pull request as draft June 23, 2022 07:02
@Xuanwo
Copy link
Member

Xuanwo commented Jun 23, 2022

@PsiACE How about adding musl build in our developing CI? Thus, we can run tests against binaries compiled under musl

@PsiACE
Copy link
Member Author

PsiACE commented Jun 23, 2022

How about adding musl build in our developing CI?

OK, maybe it could be ci (optional)?

@Xuanwo
Copy link
Member

Xuanwo commented Jun 23, 2022

I think it should be required as our users will uses musl binaries unlike macos which only used during development.

@PsiACE
Copy link
Member Author

PsiACE commented Jun 23, 2022

status

 = note: /usr/local/bin/../lib/gcc/x86_64-linux-musl/9.4.0/../../../../x86_64-linux-musl/bin/ld: /workspace/target/x86_64-unknown-linux-musl/debug/deps/libtikv_jemalloc_sys-5844e04c26a2be2a.rlib(prof_sys.pic.o): in function `prof_sys_thread_name_read_impl':
          /workspace/target/x86_64-unknown-linux-musl/debug/build/tikv-jemalloc-sys-a78278ea6c036ae2/out/build/src/prof_sys.c:308: undefined reference to `pthread_getname_np'
          collect2: error: ld returned 1 exit status
 = note: /usr/local/bin/../lib/gcc/x86_64-linux-musl/9.4.0/../../../../x86_64-linux-musl/bin/ld: /workspace/target/x86_64-unknown-linux-musl/debug/deps/libpprof-bdadb69d0c718f88.rlib(pprof-bdadb69d0c718f88.pprof.ea33fd15-cgu.7.rcgu.o): in function `pprof::profiler::write_thread_name':
          /opt/rust/cargo/registry/src/github.com-1ecc6299db9ec823/pprof-0.9.1/src/profiler.rs:193: undefined reference to `pthread_getname_np'
          collect2: error: ld returned 1 exit status

cc @Xuanwo @everpcpc

@Xuanwo
Copy link
Member

Xuanwo commented Jun 23, 2022

Please wait for tikv/pprof-rs#140

@Xuanwo
Copy link
Member

Xuanwo commented Jun 27, 2022

@PsiACE pprof-rs v0.10.0 has been released, please try again: https://crates.io/crates/pprof

@Xuanwo Xuanwo changed the title chore(deps): bump pprof and tikv-jemalloc again, for musl 1.2.3 chore(deps): bump pprof again for musl 1.2.3 Jun 27, 2022
@Xuanwo Xuanwo marked this pull request as ready for review June 27, 2022 08:56
@Xuanwo Xuanwo requested review from everpcpc and removed request for everpcpc June 27, 2022 08:57
@BohuTANG BohuTANG merged commit 2be30e2 into databendlabs:main Jun 27, 2022
@PsiACE PsiACE deleted the revert branch July 5, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants