Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(expr): add new crate common-expression #6576

Merged
merged 12 commits into from
Jul 13, 2022
Merged

feat(expr): add new crate common-expression #6576

merged 12 commits into from
Jul 13, 2022

Conversation

andylokandy
Copy link
Collaborator

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Initial commit for the new scalar expression framework. See tracking issue for more information.

  • Expression definition
  • Expression type checker
  • Expression evaluator

@vercel
Copy link

vercel bot commented Jul 12, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jul 13, 2022 at 4:50AM (UTC)

@andylokandy andylokandy changed the title feature(expr): Add new crate common-expression feat(expr): add new crate common-expression Jul 12, 2022
@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Jul 12, 2022
@andylokandy andylokandy mentioned this pull request Jul 12, 2022
Closed
33 tasks
@datafuselabs datafuselabs deleted a comment from mergify bot Jul 12, 2022
@andylokandy
Copy link
Collaborator Author 

ERROR the following files don't have a valid license header: 
common/expression/tests/it/testdata/run-ast

How can I bypass this check for goldenfiles?

@PsiACE
Copy link
Member

PsiACE commented Jul 12, 2022

How can I bypass this check for goldenfiles?

edit https://github.com/datafuselabs/databend/blob/main/.licenserc.yaml

@andylokandy
Copy link
Collaborator Author

@PsiACE But why common-ast bypass the check without being included in this config?

@Xuanwo
Copy link
Member

Xuanwo commented Jul 12, 2022

@PsiACE But why common-ast bypass the check without being included in this config?

Nice question, I did some research:

https://github.com/apache/skywalking-eyes/blob/9b6b981a99fb9179f1c5aa58ac6474ea1dbdd552/pkg/header/config.go#L143

skywalking-eyes will ignore all *.txt files, and common-ast's golden files are suffixed by .txt.

sundy-li
sundy-li approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@sundy-li sundy-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, yet needs to cover the Object Column.

@andylokandy andylokandy marked this pull request as draft July 12, 2022 18:06
@andylokandy andylokandy marked this pull request as ready for review July 12, 2022 18:32
@sundy-li

This comment was marked as outdated.

Sign in to view
@ZeaLoVe

This comment was marked as outdated.

Sign in to view
@BohuTANG

This comment was marked as outdated.

Sign in to view
@youngsofun

This comment was marked as outdated.

Sign in to view
@youngsofun youngsofun mentioned this pull request Jul 13, 2022
Merged
@Xuanwo
Copy link
Member

Xuanwo commented Jul 13, 2022

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2022

update

✅ Branch has been successfully updated

@mergify mergify bot merged commit 75b7dc7 into datafuselabs:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygf11 ygf11 ygf11 left review comments

@Xuanwo Xuanwo Xuanwo left review comments

@PsiACE PsiACE PsiACE left review comments

@sundy-li sundy-li sundy-li approved these changes

@leiysky leiysky leiysky approved these changes

@BohuTANG BohuTANG Awaiting requested review from BohuTANG

@xudong963 xudong963 Awaiting requested review from xudong963

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@andylokandy @PsiACE @Xuanwo @sundy-li @ZeaLoVe @BohuTANG @youngsofun @ygf11 @leiysky