Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add create database from share SQL, add proto conv test #7288

Merged
merged 5 commits into from
Aug 25, 2022
Merged

feat: add create database from share SQL, add proto conv test #7288

merged 5 commits into from
Aug 25, 2022

Conversation

lichuang
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

[Summary about this PR](feat: add create database from share SQL)

  1. add create database from share SQL support, note that cannot create db from share and assign engine at the same time.
  2. create_database and drop_database add share support.
  3. add proto conv test.

Fixes #issue

@vercel
Copy link

vercel bot commented Aug 25, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Aug 25, 2022 at 2:20PM (UTC)

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Aug 25, 2022
drmingdrmer
drmingdrmer reviewed Aug 25, 2022
View reviewed changes
src/meta/proto-conv/tests/it/proto_conv.rs Show resolved Hide resolved
src/meta/proto-conv/tests/it/proto_conv.rs Show resolved Hide resolved
src/meta/proto-conv/tests/it/proto_conv.rs Outdated Show resolved Hide resolved
src/meta/proto-conv/tests/it/proto_conv.rs Show resolved Hide resolved
src/meta/proto-conv/tests/it/proto_conv.rs Outdated Show resolved Hide resolved
src/meta/proto-conv/tests/it/proto_conv.rs Outdated Show resolved Hide resolved
src/meta/proto-conv/tests/it/proto_conv.rs Outdated Show resolved Hide resolved
drmingdrmer
drmingdrmer approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the {, everything is fine to me:D

@mergify mergify bot merged commit e46c90c into datafuselabs:main Aug 25, 2022
@lichuang lichuang deleted the create_db_from_share branch November 15, 2022 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drmingdrmer drmingdrmer drmingdrmer approved these changes

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create database from share
3 participants
@lichuang @drmingdrmer @Xuanwo