Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a default impl for RaftStorage::first_known_log_id() #62

Closed
Tracked by #39
drmingdrmer opened this issue Jan 4, 2022 · 3 comments
Closed
Tracked by #39

Provide a default impl for RaftStorage::first_known_log_id() #62

drmingdrmer opened this issue Jan 4, 2022 · 3 comments
Assignees
@GrapeBaBa
Labels
A-store Area: storage good first issue Good for newcomers

Comments

@drmingdrmer
Copy link
Member

drmingdrmer commented Jan 4, 2022 •
edited

first_known_log_id() returns the oldest log id that is found in logs or the last applied log id.

This method by default does not need users to impl it manually.
It can be done with first_id_in_log() and last_applied_state().

openraft/openraft/src/storage.rs

Line 175 in 9b00e7c

async fn first_known_log_id(&self) -> Result<LogId, StorageError>;

@drmingdrmer drmingdrmer mentioned this issue Jan 4, 2022
Closed
3 tasks
@github-actions
Copy link

github-actions bot commented Jan 4, 2022

👋 Thanks for opening this issue!

Get help or engage by:

  • /help : to print help messages.
  • /assignme : to assign this issue to you.

@drmingdrmer drmingdrmer added good first issue Good for newcomers A-store Area: storage labels Jan 4, 2022
@GrapeBaBa
Copy link
Contributor

/assignme

mergify bot added a commit that referenced this issue Jan 5, 2022
@mergify
Merge pull request #65 from GrapeBaBa/issue_62
0552ffb 
[#62]Make first_known_log_id default impl
@drmingdrmer
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GrapeBaBa GrapeBaBa

Labels
A-store Area: storage good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drmingdrmer @GrapeBaBa