Refactor: error system; add Fatal and API errors #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add: Fatal as a collection of all errors that will shutdown a raft node. Currently it has only one sub-error: StorageError. - Add: error types for every API, such as AppendEntriesError or VoteError. - Remove: `map_storage_error()` and `map_fatal_storage_error()`. A fatal error should be popped up and be dealt with at the top level. Avoid changing target state everywhere, which is hard to review or debug. - Use crate anyerror as a wrapper of external error. - Remove: RaftError, which is vague about what it is for. - Makes API error serializable for transport.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Refactor: error system; add Fatal and API errors
Add: Fatal as a collection of all errors that will shutdown a raft
node. Currently it has only one sub-error: StorageError.
Add: error types for every API, such as AppendEntriesError or
VoteError.
Remove:
map_storage_error()andmap_fatal_storage_error().A fatal error should be popped up and be dealt with at the top level.
Avoid changing target state everywhere, which is hard to review or
debug.
Use crate anyerror as a wrapper of external error.
Remove: RaftError, which is vague about what it is for.
Makes API error serializable for transport.