Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Work around some worktree-related failures #3129

Merged
merged 2 commits into from
Jan 28, 2019
Merged

TST: Work around some worktree-related failures #3129

merged 2 commits into from
Jan 28, 2019

Commits on Jan 28, 2019

  1. TST: Work around some worktree-related failures 

    Based on local testing, three tests fail with an
InvalidGitRepositoryError when executed from within a git worktree of
the codebase: test_create_sibling.test_invalid_call,
test_run_procedure.test_invalid_call (dataladgh-3052), and
test_run_procedure.test_procedure_discovery.

Avoid these errors by switching to a temporary, non-repo directory
before running the tests.

Re: datalad#3029
Fixes datalad#3052.
    @kyleam
    kyleam committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    9e831c6 View commit details
    Browse the repository at this point in the history

  2. ENH: wtf: Don't fail if repository is considered invalid 

    This can happen in at least one case where there isn't actually an
issue: when `datalad wtf` is called from a git worktree checkout of
the codebase.  And even if there is an issue, we should try to
describe as much as possible rather than aborting.
    @kyleam
    kyleam committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    b92ccce View commit details
    Browse the repository at this point in the history