Fix save to not force committing into git if reference dataset is pure git (not git-annex)#7355
Merged
Merged
Conversation
otherwise there is no point of having two tests - one for GitRepo and one for AnnexRepo
…aset.create otherwise it becomes an AnnexRepo and thus behaving pretty much the same way as in AnnexRepo test and actually test running the same duration. With this change we get 11.45s call datalad/support/tests/test_repo_save.py::test_annexrepo_save_all 8.14s call datalad/support/tests/test_repo_save.py::test_gitrepo_save_all thus attesting to the fact that we get different testing for GitRepo case
Although the file is about .repo.save and not ds.save, there is already a good number of other tests which pretty much test ds.save. It is also the only place which already uses that convoluted scenario so I decided it would be good place for an addition of another testing thus not introducing much of extra run time as if I was to create an independent new test for this problem.
yarikoptic
added
semver-patch
github-actions
Bot
removed
the
CHANGELOG-missing
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## maint #7355 +/- ##
==========================================
+ Coverage 88.73% 90.70% +1.97%
==========================================
Files 327 327
Lines 44567 44569 +2
Branches 5906 5906
==========================================
+ Hits 39545 40428 +883
+ Misses 5007 4126 -881
Partials 15 15
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Member
Author
|
ha -- #7353 lacked codecov report so might be due to that but here we even got |
Member
Author
|
I would even say that we as well release after this fix since it would already be useful to some folks I know ;-) |
Member
Author
|
It is as green as you can ever see a PR here, with even +1.97% boost in coverage -- what could be better? ;) I will merge unless objections voiced on Sunday. |
yarikoptic
added
the
merge-if-ok
Collaborator
|
PR released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sits on top of #7353 to reuse existing testing setup. Actual fix is few character change in
save.pyand is present in the last non-changelog commit.Closes #7351