Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace assert statements by if / raise #428

Open
DomInvivo opened this issue Aug 5, 2023 · 0 comments
Open

Replace assert statements by if / raise #428

DomInvivo opened this issue Aug 5, 2023 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@DomInvivo
Copy link
Collaborator

My understanding is that assert statements can be removed at compile time (to improve performance, which seems specifically relevant to Graphium), so any error that a downstream user can make and should be informed about should ideally be a raised and specific (e.g. RuntimeError, ValueError, TypeError, KeyError, ...) Exception. To have sanity checks during debugging / development, you can still use assert statements.

Originally posted by @cwognum in #414 (comment)

@DomInvivo DomInvivo added the enhancement New feature or request label Aug 29, 2023
@DomInvivo DomInvivo added this to the Graphium 2.0 milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant