Mike's changes incl. psd update

dbatools.psd1

@@ -11,7 +11,7 @@
 	RootModule = 'dbatools.psm1'
 
 	# Version number of this module.
-	ModuleVersion = '0.8.5.1'
+	ModuleVersion = '0.8.5.2'
 
 	# ID used to uniquely identify this module
 	GUID = '9d139310-ce45-41ce-8e8b-d76335aa1789'
@@ -129,7 +129,8 @@
 		'Test-DbaDiskAllocation',
 		'Test-DbaPowerPlan',
 		'Set-DbaPowerPlan',
-		'Test-DbaDiskAlignment'
+		'Test-DbaDiskAlignment',
+		'Get-DbaDatabaseFreespace'
 	)
 
 	# Cmdlets to export from this module

functions/Get-DbaDatabaseFreespace.ps1

@@ -0,0 +1,139 @@
+function Get-DbaDatabaseFreespace{
+<#
+.SYNOPSIS
+Returns database file space information for database files on a SQL instance.
+
+.DESCRIPTION
+This function returns database file space information for a SQL Instance or group of SQL 
+Instances. Information is based on a query against sys.database_files and the FILEPROPERTY
+function to query and return information. The function can accept a single instance or
+multiple instances. By default, only user dbs will be shown, but using the IncludeSystemDBs
+switch will include system databases
+
+.NOTES 
+Original Author: Michael Fal (@Mike_Fal), http://mikefal.net
+
+File free space script borrowed and modified from Glenn Berry's DMV scripts (http://www.sqlskills.com/blogs/glenn/category/dmv-queries/)
+
+dbatools PowerShell module (https://dbatools.io, clemaire@gmail.com)
+Copyright (C) 2016 Chrissy LeMaire
+
+This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.
+
+This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+You should have received a copy of the GNU General Public License
+along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+.PARAMETER SqlServer
+SQLServer name or SMO object representing the SQL Server to connect to. This can be a
+collection and recieve pipeline input
+
+.PARAMETER SqlCredential
+PSCredential object to connect under. If not specified, currend Windows login will be used.
+
+.PARAMETER IncludeSystemDBs
+Switch parameter that when used will display system database information
+
+.LINK
+https://dbatools.io/Get-DbaDatabaseFreespace
+
+.EXAMPLE
+Get-DbaDatabaseFreespace -SqlServer localhost
+
+Returns all user database files and free space information for the local host
+
+.EXAMPLE
+Get-DbaDatabaseFreespace -SqlServer localhost | Where-Object {$_.PercentUsed -gt 80}
+
+Returns all user database files and free space information for the local host. Filters
+the output object by any files that have a percent used of greater than 80%.
+
+.EXAMPLE
+@('localhost','localhost\namedinstance') | Get-DbaDatabaseFreespace
+
+Returns all user database files and free space information for the localhost and
+localhost\namedinstance SQL Server instances. Processes data via the pipeline.
+#>
+    [CmdletBinding(SupportsShouldProcess = $true)]
+    param([parameter(ValueFromPipeline,Mandatory = $true)]
+		[Alias("ServerInstance", "SqlInstance")]
+		[object[]]$SqlServer
+		,[System.Management.Automation.PSCredential]$SqlCredential
+        ,[switch] $IncludeSystemDBs)
+    BEGIN{
+        $outputraw = @()
+        $sql = @'
+SELECT 
+    @@SERVERNAME as SqlServer
+    ,DB_NAME() as DBName
+    ,f.name AS [FileName]
+    ,fg.name AS [Filegroup] 
+    ,f.physical_name AS [PhysicalName]
+    ,CAST(CAST(FILEPROPERTY(f.name, 'SpaceUsed') AS int)/128.0 AS DECIMAL(15,2)) as [UsedSpaceMB]
+    ,CAST(f.size/128.0 - CAST(FILEPROPERTY(f.name, 'SpaceUsed') AS int)/128.0 AS DECIMAL(15,2)) AS [FreeSpaceMB]
+    ,CAST((f.size/128.0) AS DECIMAL(15,2)) AS [FileSizeMB]
+    ,CAST((FILEPROPERTY(f.name, 'SpaceUsed')/(f.size/1.0)) * 100 as DECIMAL(15,2)) as [PercentUsed]
+FROM sys.database_files AS f WITH (NOLOCK) 
+LEFT OUTER JOIN sys.filegroups AS fg WITH (NOLOCK)
+ON f.data_space_id = fg.data_space_id
+'@
+    }
+
+    PROCESS{
+        foreach($s in $SqlServer){
+        #For each SQL Server in collection, connect and get SMO object
+        Write-Verbose "Connecting to $SqlServer"
+		$server = Connect-SqlServer $SqlServer -SqlCredential $SqlCredential
+            #If IncludeSystemDBs is true, include systemdbs
+            #only look at online databases (Status equal normal)
+            try{
+                if($IncludeSystemDBs){
+                        $dbs = $server.Databases | Where-Object {$_.status -eq 'Normal'}
+                    } else {
+                        $dbs = $server.Databases | Where-Object {$_.status -eq 'Normal' -and $_.IsSystemObject -eq 0}
+                    }
+                }
+            catch{
+                Write-Exception $_
+                    throw "Unable to gather dbs for $($s.name)"
+                    continue
+                }
+
+            foreach($db in $dbs){
+                try{
+                    Write-Verbose "Querying $($s) - $($db.name)."
+                    #Execute query against individual database and add to output
+                    $outputraw += ($db.ExecuteWithResults($sql)).Tables[0]
+                    } 
+                catch {
+                    Write-Exception $_
+                    throw "Unable to query $($s) - $($db.name)"
+                    continue
+                }
+            }
+        }
+    }
+    END{
+        #Sanitize output into array of custom objects, not DataRow objects
+        Write-Verbose 'Sanitizing outupt, converting DataRow to custom PSObject.'
+        $output = @()
+        foreach($row in $outputraw){
+            $outrow = [ordered]@{'SqlServer'=$row.SqlServer;`
+                                 'DatabaseName'=$row.DBName;`
+                                 'FileName'=$row.FileName;`
+                                 'FileGroup'=$row.FileGroup;`
+                                 'PhysicalName'=$row.PhysicalName;`
+                                 'UsedSpaceMB'=$row.UsedSpaceMB;`
+                                 'FreeSpaceMB'=$row.FreeSpaceMB;`
+                                 'FileSizeMB'=$row.FileSizeMB;`
+                                 'PercentUsed'=$row.PercentUSed}
+            $output += New-Object psobject -Property $outrow
+        }
+
+
+        return $output
+    }
+}

functions/Test-SqlTempDBConfiguration.ps1

@@ -146,10 +146,10 @@ Checks tempdb on the localhost machine.
 		Write-Verbose "File counts evaluated"
 
 		#test file growth
-		$percdata = $datafiles.Rows | Where-Object { $_.GrowthType -ne 'KB' }
-		$perclog =  $logfiles.Rows  | Where-Object { $_.GrowthType -ne 'KB' }
+		$percdata = $datafiles | Where-Object { $_.GrowthType -ne 'KB' } | Measure-Object
+		$perclog =  $logfiles  | Where-Object { $_.GrowthType -ne 'KB' } | Measure-Object
 
-		$totalcount = $percdata.rows.count + $perclog.rows.count
+		$totalcount = $percdata.count + $perclog.count
 		if ($totalcount -gt 0) { $totalcount = $true } else { $totalcount = $false }
 
 		$value = [PSCustomObject]@{
@@ -174,7 +174,7 @@ Checks tempdb on the localhost machine.
 		Write-Verbose "File growth settings evaluated"
 		#test file Location
 
-		$cdata = ($datafiles.rows | Where-Object { $_.FileName -like 'C:*' }).Rows.Count + ($logfiles | Where-Object { $_.FileName -like 'C:*' }).Rows.Count
+		$cdata = ($datafiles | Where-Object { $_.FileName -like 'C:*' } | Measure-Object).Count + ($logfiles | Where-Object { $_.FileName -like 'C:*' } | Measure-Object).Count
 		if ($cdata -gt 0) { $cdata = $true } else { $cdata = $false }
 
 		$value = [PSCustomObject]@{
@@ -199,7 +199,7 @@ Checks tempdb on the localhost machine.
 		Write-Verbose "File locations evaluated"
 
 		#Test growth limits
-		$growthlimits = ($datafiles.rows | Where-Object { $_.MaxSize -gt 0 }).Count + ($logfiles.rows | Where-Object { $_.MaxSize -gt 0 }).Count
+		$growthlimits = ($datafiles | Where-Object { $_.MaxSize -gt 0 } | Measure-Object).Count + ($logfiles | Where-Object { $_.MaxSize -gt 0 } | Measure-Object).Count
 		if ($growthlimits -gt 0) { $growthlimits = $true } else { $growthlimits = $false }
 
 		$value = [PSCustomObject]@{