-
-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial commit of Move-DbaDatabaseFile (renamed from Move-SqlDatabaseFile) #250
Conversation
In order to resolve this conflict can you please remove the Move-SqlDatabaseFile from development branch? |
Move-SqlDatabaseFile has been removed per your request, @ClaudioESSilva |
@ConstantineK do you have an environment where you can test this for @ClaudioESSilva? If so, do you have time this week? Here is the QA Checklist
|
Just going through the documentation and doing some spelling and grammar checks, and had a note/question: I think the comment on InputFile may be incorrect. When I look at https://github.com/sqlcollaborative/dbatools/pull/250/files#diff-c7029173690c770eeb46aa4e8c21f664R775 I dont see any dependency on -ExportDatabaseStructure. |
Ran through the comments and documentation, changed a bunch of grammar and phrasing to shorten and hopefully simplify some of the explanations. Altered -InputFile fundamentally because I think the explanation may have been copy pasted and not changed. Changed capitalization and period use to be more consistent.
@ConstantineK you're right. |
Test results: Just a quick question/note: by default, are we saying that not supporting 2000 is a blocker? Just seeing a few issues whenever I run these example commands on a 2000 box I get errors.
|
@ConstantineK can you confirm that you are using last commit (yesterday)? |
Moved to November release cycle as it requires special, time consuming attention and loving. |
the english is confirmed proper
Correction of 2 bugs related with SQL2000. - error in query. was mention an alias that does not exists - there is a bug where filename returned from SQL 2000 comes with NULL plus SPACE characters. Here we get rid of them. - DbccCheckDb - Changed from NoDbccCheckDb to DbccCheckDB. When dealing with some big databases you may not want to run this command right away. This way you can choose when use it
- sysaltfiles name and filename columns are nchar datatypes. Changed the query to remove them.
This would imply moving code from Copy-SqlDatabase to internal folder. Also some of that code need to be rewrite. This would need too much testing including the Copy-SqlDatabase command. Too risky.
Should this PR be removed and resubmitted later? It hasn't moved in quite some time and I never know what to do with it but hope ;) |
Claudio had asked the question and I had answered it in slack, sorry about that. As far as I know the same issues I had reported were present. |
@ConstantineK I have made few changes since your review. The principal issue was with sql 2000 that we decide to not support. |
I will be trying this today and get back to you, thanks @ClaudioESSilva! |
…ewCommand_Move-SqlDatabaseFile
I had an issue with snapshots. We need to either fix or ignore snapshots with warning.
|
I also had some other issues. Do you have time to work on this today? I was surprised to see that I could not specify a destination path -- I had to interact with GUI, which I'd like to fix. Or did I miss something?
|
@ClaudioESSilva I'd like to include this one in v1 -- any chance we can aim for the feb 14 release? |
Was not returning the hash but the full object. The comparation was failing when it should return OK
Looks like I got an error, I did put the destination file path in the csv
|
Issue addressed @ConstantineK |
We will attack this as a team closer to 1.0. Closing PR but have backups of code. |
No description provided.