Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install-DbaMaintenanceSolution implement -WhatIf #4924

Merged
merged 1 commit into from
Jan 10, 2019

Conversation

ijeb
Copy link

@ijeb ijeb commented Jan 9, 2019

Type of Change

  • Bug fix (non-breaking change, fixes Install-DbaMaintenanceSolution Ignores -WhatIf #4901 )
  • New feature (non-breaking change, adds functionality)
  • Breaking change (effects multiple commands or functionality)
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

Approach

Add $Pscmdlet.ShouldProcess and some small fixes

Commands to test

Install-DbaMaintenanceSolution -SqlInstance vmSQL -WhatIf
Install-DbaMaintenanceSolution -SqlInstance vmSQL -InstallJobs -WhatIf
Install-DbaMaintenanceSolution -SqlInstance vmSQL -InstallJobs -ReplaceExisting -WhatIf
Install-DbaMaintenanceSolution -SqlInstance vmSQL -InstallJobs -ReplaceExisting -Force -WhatIf
Install-DbaMaintenanceSolution -SqlInstance vmSQL -InstallJobs -ReplaceExisting -Solution Backup -WhatIf
Install-DbaMaintenanceSolution -SqlInstance vmSQL -ReplaceExisting -WhatIf

@potatoqualitee
Copy link
Member

oh, man, horrifying. thank you for this fix!

@potatoqualitee potatoqualitee merged commit c913e32 into development Jan 10, 2019
@potatoqualitee potatoqualitee deleted the ijeb-patch-2 branch January 10, 2019 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install-DbaMaintenanceSolution Ignores -WhatIf
2 participants