Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to resolve Issue 5443 #5521

Merged
merged 2 commits into from May 14, 2019
Merged

Changes to resolve Issue 5443 #5521

merged 2 commits into from May 14, 2019

Conversation

sqllensman
Copy link
Contributor

Type of Change

  • Bug fix (non-breaking change, fixes [Bug] Export-DbaCredential - -Identity doesn't filter, DAC duplication problem #5443
  • New feature (non-breaking change, adds functionality)
  • Breaking change (effects multiple commands or functionality)
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

Purpose

Correct bug by removing connection pooling and adding proper filtering

@potatoqualitee
Copy link
Member

Love that Pooling=$false!! Solves a long-time problem, thank you! 💯

@potatoqualitee potatoqualitee merged commit 041830b into dataplat:development May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Export-DbaCredential - -Identity doesn't filter, DAC duplication problem
2 participants
@sqllensman @potatoqualitee