Refactoring of Copy-DbaCredential and Export-DbaCredential

[andreasjordan]

General refactoring to be able to open DAC inside of Copy-DbaCredential.
Fixed some issues with QUOTENAME of credential name

Still open: Opening DAC in Export like in Copy. Will have to save all the $server variables to be able to disconnect at the end.

[potatoqualitee]

Should this be ComputerName instead? I feel like there are sometimes problems with DomainInstanceName. Perhaps it's not always filled out or accurate.

[wsmelton]

SourceServer is used for the output object in all the Copy commands @potatoqualitee

[wsmelton]

Oh, you are referring to property name? If that, yes we use ComputerName for the value in other commands.

[potatoqualitee]

Thank you for double checking 😊

[wsmelton]

Also looks like Connect object does checks for populating ComputerName

dbatools/functions/Connect-DbaInstance.ps1

Lines 1573 to 1592 in 3d8d330

	if ($server.DatabaseEngineType -ne "SqlAzureDatabase") {
	try {
	Write-Message -Level Debug -Message "we try to use server.NetName for computername"
	$computername = $server.NetName
	} catch {
	Write-Message -Level Debug -Message "Ups, failed so we use instance.ComputerName"
	$computername = $instance.ComputerName
	}
	Write-Message -Level Debug -Message "Ok, computername = server.NetName = '$computername'"
	}
	# SQL on Linux is often on docker and the internal name is not useful
	if (-not $computername -or $server.HostPlatform -eq "Linux") {
	Write-Message -Level Debug -Message "SQL on Linux is often on docker and the internal name is not useful - we use instance.ComputerName as computername"
	$computername = $instance.ComputerName
	Write-Message -Level Debug -Message "Ok, computername is now '$computername'"
	}
	Write-Message -Level Debug -Message "We add IsAzure = '$false', ComputerName = computername = '$computername', DbaInstanceName = instance.InstanceName = '$($instance.InstanceName)', NetPort = instance.Port = '$($instance.Port)', ConnectedAs = server.ConnectionContext.TrueLogin = '$($server.ConnectionContext.TrueLogin)'"
	Add-Member -InputObject $server -NotePropertyName IsAzure -NotePropertyValue $false -Force
	Add-Member -InputObject $server -NotePropertyName ComputerName -NotePropertyValue $computername -Force
	Add-Member -InputObject $server -NotePropertyName DbaInstanceName -NotePropertyValue $instance.InstanceName -Force

[andreasjordan]

No, we don't need the computername here, but "SqlInstance". This is the output from the currently released code:

And we mostly fill "SqlInstance" using ".DomainInstanceName", just search for "SqlInstance = $server.DomainInstanceName" in the code.

We can not use ".Name" of "$server", as this has the prefix "ADMIN:" when using a DAC - and I think we don't want to have that in the output.

[potatoqualitee]

ahhhh make sense, thanks

[potatoqualitee]

Thank you 🙇🏼