[Set-DbaAgentJobStep] - Added ShouldProcess to the Rename to fix #8140 #8141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try { | ||
| Write-Message -Message "Changing the job step '$StepName' for job '$j' on $server" -Level Verbose |
There was a problem hiding this comment.
Verbose message not needed, as ShouldProcess always writes verbose output.
There was a problem hiding this comment.
it's true! I didnt realize this until years later. I'm going to merge nevertheless, since this is an important change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
.\tests\manual.pester.ps1)Purpose
Approach
Commands to test
Screenshots
Learning