Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invoke-DbaDbLogShipping / New-DbaLogShippingPrimaryDatabase - Fix issues with backup compression #8156

Merged
merged 1 commit into from Feb 9, 2022
Merged

Invoke-DbaDbLogShipping / New-DbaLogShippingPrimaryDatabase - Fix issues with backup compression #8156

merged 1 commit into from Feb 9, 2022

Conversation

andreasjordan
Copy link
Contributor

Type of Change

  • Bug fix (non-breaking change, fixes Invoke-DbaDbLogShipping -CompressBackup doesn't work #8155 )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (effects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

@sanderstad
Copy link
Contributor

Looks good to me, thanks!,
We probably should change the parameter type for SqlInstance but that's something I will look at later

@potatoqualitee potatoqualitee merged commit c470fce into development Feb 9, 2022
@potatoqualitee potatoqualitee deleted the NewDbaLogShippingPrimaryDatabase_fix_compression branch February 9, 2022 16:47
@potatoqualitee
Copy link
Member

Thank you both 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderstad sanderstad sanderstad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invoke-DbaDbLogShipping -CompressBackup doesn't work
3 participants
@andreasjordan @sanderstad @potatoqualitee